Fix #522: Catch authorization errors and prevent auto-rejoining#571
Closed
tristan-maksad wants to merge 1 commit intoPsycheFoundation:mainfrom
Closed
Fix #522: Catch authorization errors and prevent auto-rejoining#571tristan-maksad wants to merge 1 commit intoPsycheFoundation:mainfrom
tristan-maksad wants to merge 1 commit intoPsycheFoundation:mainfrom
Conversation
…-rejoining. - backend.rs: Detect AccountNotInitialized authorization errors, throwing cleaner error - app.rs: Exit with exit code 11 when said authorization error occurs - train_entrypoint.sh: Skip auto-rejoining at exit code 11
Contributor
|
Hey! Thank you for your contribution, all of this functionality is already handled in #514. We now check for authorization before joining the run when using the run manager, so we won’t retry if there’s no authorization, and the error message is clear now. We forgot to link that PR to the issue, sorry for that but thanks anyway for your work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users try to join a run without an authorized account, the client throws a cryptic error and will problematically continue to auto-rejoin. This pull request catches the "AccountNotInitialized" authorization errors and now throws a cleaner error, then exits Psyche. The docker wrapper no longer auto-rejoins when such errors occur.
Specific File Changes: