Feat/asset issuer normalization qa#926
Closed
Chrisbankz0 wants to merge 4 commits into
Closed
Conversation
added 2 commits
May 26, 2026 22:04
…n regression tests and add crowdfund KPI computation logic with API support.
Contributor
|
@Chrisbankz0 fix conflicts |
|
@Chrisbankz0 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Chrisbankz0 fix workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes
#875
Summary
This Pull Request implements two major features for the LumenPulse data-processing service:
GET /crowdfund/metrics.1. Asset Issuer Normalization
xlm,native, etc.) and issued assets (alphanum4/alphanum12) with G-address validation.Optionaltypes for runtimeNoneparameter handling, and resolved static type checking errors with appropriate type-ignore annotations.2. Crowdfund Vault Event KPI Computation
GET /crowdfund/metricsin server.py.Linked Issue
Closes #734
Type of Change
Validation
Test Results
Run pytest specifically for the newly introduced tests:
pytest tests/test_asset_normalizer.py -v(83 tests passed)pytest tests/unit/test_crowdfund_metrics.py -v(all tests passed)Documentation
Checklist
feat/,fix/, ordocs/(Current branch:feat/asset-issuer-normalization-qa)