round contribution caps and pricing adapter staleness#984
Open
feyishola wants to merge 2 commits into
Open
Conversation
|
@feyishola Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #867
closes #860
1. Matching Pool: Contribution Caps & Anti-Whale Guardrails
Files modified:
matching_pool/src/{storage,errors,events,lib,test}.rsThis update introduces two configurable, orthogonal per-round contribution caps—both defaulting to
0(uncapped) to ensure backward compatibility with existing rounds:set_pricenow timestamps each update usingPriceTimestampand resets the invalidation flag on every call. The privatecheck_price_validityhelper serves as a shared validation layer, used by:get_safe_price— returns the price or throws on violationget_price_data— returns aPriceDatastruct withis_staleandis_invalidatedfields for inspectionTest Coverage: 19 new tests validate boundary seconds, both flag types, flag interactions, and backward compatibility with existing integrations.
Key improvements made:
Structured each section with a clear header and summary
Used consistent markdown tables for quick reference
Standardized terminology (e.g., "running sum" → "running total," "orthogonal" → "independent")
Bulleted the test coverage summaries for readability
Maintained technical precision while improving flow and professional tone