Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions example/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ source 'https://rubygems.org'
# You may use http://rbenv.org/ or https://rvm.io/ to install and use this version
ruby ">= 2.6.10"

# Exclude problematic versions of cocoapods and activesupport that causes build failures.
# Exclude problematic CocoaPods and concurrent-ruby versions that cause build failures.
gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1'
gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0'
gem 'xcodeproj', '< 1.26.0'
gem 'concurrent-ruby', '< 1.3.4'
Comment on lines 7 to 9
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 activesupport 7.1.0 exclusion silently dropped

The previous Gemfile held gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0' with a comment that explicitly called out activesupport 7.1.0 as causing build failures. Removing the entire line also removes the != 7.1.0 guard. If Bundler resolves activesupport to exactly 7.1.0 (still technically possible if the cocoapods gem's own gemspec allows it), iOS CocoaPods-dependent builds could break. Consider adding a scoped re-exclusion if the 7.1.0 bug is still relevant:

Suggested change
gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1'
gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0'
gem 'xcodeproj', '< 1.26.0'
gem 'concurrent-ruby', '< 1.3.4'
gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1'
gem 'activesupport', '!= 7.1.0'
gem 'xcodeproj', '< 1.26.0'
gem 'concurrent-ruby', '< 1.3.4'

This removes the lower-bound that was triggering Dependabot alerts (by no longer declaring a range that covers vulnerable versions) while still protecting against the known broken release.

Prompt To Fix With AI
This is a comment left during a code review.
Path: example/Gemfile
Line: 7-9

Comment:
**`activesupport 7.1.0` exclusion silently dropped**

The previous Gemfile held `gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0'` with a comment that explicitly called out activesupport 7.1.0 as causing build failures. Removing the entire line also removes the `!= 7.1.0` guard. If Bundler resolves activesupport to exactly 7.1.0 (still technically possible if the cocoapods gem's own gemspec allows it), iOS CocoaPods-dependent builds could break. Consider adding a scoped re-exclusion if the 7.1.0 bug is still relevant:

```suggestion
gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1'
gem 'activesupport', '!= 7.1.0'
gem 'xcodeproj', '< 1.26.0'
gem 'concurrent-ruby', '< 1.3.4'
```
This removes the lower-bound that was triggering Dependabot alerts (by no longer declaring a range that covers vulnerable versions) while still protecting against the known broken release.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Cursor Fix in Codex

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,14 @@
"basic-ftp": ">=5.2.2",
"brace-expansion": "~1.1.13",
"cacache/glob": "^10.5.0",
"flatted": ">=3.3.4",
"flatted": ">=3.4.2",
"handlebars": ">=4.7.9",
"js-yaml": "^4.1.1",
"lodash": ">=4.18.0",
"lodash-es": ">=4.18.0",
"minimatch": "~3.1.3",
"picomatch@npm:^4.0.2": "4.0.4",
"picomatch@npm:^4.0.3": "4.0.4",
"fast-xml-parser": ">=4.5.4",
"tar": ">=7.5.10",
"undici": ">=7.24.0"
Expand Down
14 changes: 7 additions & 7 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6740,10 +6740,10 @@ __metadata:
languageName: node
linkType: hard

"flatted@npm:>=3.3.4":
version: 3.4.1
resolution: "flatted@npm:3.4.1"
checksum: c98e458fac822c3d6f814e38154f9f5c7aa4b10c259467beda05740596cf9a826754a7a77b840b8ca2926a3e22a6f3a27992f0c673a9dbb4f6ea9f132e9a9db4
"flatted@npm:>=3.4.2":
version: 3.4.2
resolution: "flatted@npm:3.4.2"
checksum: 1b2536fccbbf75d67a823dea67819f764c19266ad5e4aca6b47f6bf84d3b5e1c15eb5862f7dec1fb87129b60741524933192051286de52baddbc97129896380d
languageName: node
linkType: hard

Expand Down Expand Up @@ -10865,9 +10865,9 @@ __metadata:
linkType: hard

"picomatch@npm:^4.0.2, picomatch@npm:^4.0.3":
version: 4.0.3
resolution: "picomatch@npm:4.0.3"
checksum: 6817fb74eb745a71445debe1029768de55fd59a42b75606f478ee1d0dc1aa6e78b711d041a7c9d5550e042642029b7f373dc1a43b224c4b7f12d23436735dba0
version: 4.0.4
resolution: "picomatch@npm:4.0.4"
checksum: 76b387b5157951422fa6049a96bdd1695e39dd126cd99df34d343638dc5cdb8bcdc83fff288c23eddcf7c26657c35e3173d4d5f488c4f28b889b314472e0a662
languageName: node
linkType: hard

Expand Down
Loading