Fix inconsistent repo picker: use dropdown in both new session and multi-agent flows#404
Open
StephaneDelcroix wants to merge 1 commit intomainfrom
Open
Conversation
…w multi-agent flows
The 'New Session' form (CreateSessionForm.razor) used a <select> dropdown for
repository selection, while the 'New Multi-Agent' flow (SessionSidebar.razor)
used a list of clickable buttons. This was confusing for users.
Changes:
- Replace button list in multi-agent Step 1 with <select class="ns-repo-select">
dropdown, matching the CreateSessionForm pattern
- Add placeholder option ('Pick a repo') for the dropdown
- Show ns-repo-label when there's only 1 repo (matches single-repo behavior)
- Auto-advance to Step 2 (preset picker) when there's exactly 1 repo
- Add OnMultiAgentRepoChanged handler for the dropdown's onchange event
Tests:
- Add RepoPickerConsistencyTests.cs with 8 tests verifying both forms use
the same <select> pattern, ns-repo-select class, single-repo label, and
auto-advance behavior
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In 'New Session' the repository selector is a
<select>dropdown, but in 'New Multi-Agent' it was a list of clickable buttons. This inconsistency is confusing.Fix
Changed the multi-agent repo picker (Step 1 in SessionSidebar.razor) from a button list to a
<select>dropdown matching CreateSessionForm:<select class="ns-repo-select">dropdown with placeholder option<div class="ns-repo-label">label (auto-advances to Step 2)Also added
OnMultiAgentRepoChangedhandler and auto-advance logic when there's exactly 1 repo.Tests
Added
RepoPickerConsistencyTests.cs(8 tests) verifying:<select>withns-repo-selectclassAll 2760 tests pass.