Only special functions#3
Open
tmbb wants to merge 7 commits into
Open
Conversation
Author
|
Note that some tests fail because either the error is too big or the value is outside the tolerance. We have to decide what to do with those functions (I believe I'm not making any mistakes in the testing code) |
Owner
|
Sorry for the delay, I'll try to find some time to look at this soon! Thanks for the efforts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new PR with only the special functions and no elixir code (we probably don't even need it anymore as we've already added all the functions that could be added through simple string manipulation).
@PvdBerg1998 please review this one instead