feat: Add parsing definitions from the api calls#1252
Merged
SjurSutterudSagen merged 12 commits intoMay 11, 2026
Merged
Conversation
Still need to figure out the state handling, since when i console log what is returned it returns correctly, and then runs again (for the data?) and empties the state with the definitions. Co-authored-by: Copilot <copilot@github.com>
Branch Deployment to Cloudflare Pages🚛 Preview URL: https://b1296e3f.pxweb2.pages.dev |
…nals in mapDefinitions function
SjurSutterudSagen
changed the title
SjurSutterudSagen
requested review from
KentMossback,
MikaelNordberg,
PerIngeVaaje,
likp,
michaelpande,
oyessb and
runejo
as code owners
|
SjurSutterudSagen
deleted the
feature/PxWeb2-1037-add-collecting-definitions-from-the-api-calls
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parsing for the definitions in the metadata API call into the jsonStat2ResponseMapper, make the TableInformation component use that for the DefinitionsTab.
This will make the DefinitionsTab show up again, if the API has the correct definitions in the response.