Add getter/setter for global_header#1816
Closed
daveisfera wants to merge 1 commit intoPyAV-Org:mainfrom
Closed
Conversation
Member
|
This is not necessary, you can already read/write ptr.flags: from av.codec.context import Flags
video.codec_context.flags |= Flags.global_headerEven if this is a common operator, your PR would need proper type hints and a basic test. |
Contributor
Author
|
Awesome! This is what I was looking for and couldn't figure out. Writing down how to clear the flag in case other stumble on this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's not a better option, then this is the fix for #1814 (creating this so I can test a fully integrated build)