Enable libx265 for ffmpeg in build-deps#1835
Closed
tsnl wants to merge 1 commit intoPyAV-Org:mainfrom
Closed
Conversation
Member
|
This PR is bad because it does not think through the logical conclusions of its own premise. If adding x265 is clearly good, why not add svt-av1, aom, etc. Or even include fdk-aac with Unless you really need to test some feature of an encoder, there's no reason to include it in this script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building
FFmpegas a dependency, the current build does not includelibx265.It appears that release
PyAVversions do supportlibx265. I'm guessing this change only affects development or those who build from source.