Expose the Duration Field for Frames#1880
Merged
WyattBlue merged 1 commit intoPyAV-Org:mainfrom Apr 30, 2025
Merged
Conversation
70695f5 to
9f86191
Compare
Queuecumber
commented
Apr 29, 2025
Signed-off-by: Max Ehrlich <max.ehr@gmail.com>
Contributor
Author
|
Thanks for the fast turnaround on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the duration field on frame objects as the time that a given frame should be displayed for in
time_baseunits.This can simplify certain decode loops which are searching for specific frames in time, e.g.:
In this example the frame might not occur at the target pts so we need to use duration to check if the frame would be onscreen at the target time.
Currently this can be done by computing an average frame duration using the average frame rate (which is error prone) or trying to synchronize to the packets duration field.