Prevent segfault on data stream template#2013
Merged
WyattBlue merged 4 commits intoPyAV-Org:mainfrom Oct 2, 2025
Merged
Conversation
Contributor
Author
|
OK, clearly I'm going about this wrong. Why doesn't this in output.pyi prevent the segfault in the first place?!? class OutputContainer(Container):
...
def add_stream_from_template(
self, template: _StreamT, opaque: bool | None = None, **kwargs
) -> _StreamT: ... |
Member
|
|
Contributor
Author
|
Is there something I can do to get that Windoze smoke test to pass? |
Member
|
Windows failing seems unrelated. If you can fix this, make a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was wrongly attempting to copy a data stream using add_stream_from_template() and got a segfault instead of a useful response. This patch/test resolves.
The segfault occurs on assigning
None.codecorNone.nametocodec_obj: Codec.