Add CodecContext global_quality property binding#2083
Closed
ladaapp wants to merge 1 commit intoPyAV-Org:mainfrom
Closed
Add CodecContext global_quality property binding#2083ladaapp wants to merge 1 commit intoPyAV-Org:mainfrom
ladaapp wants to merge 1 commit intoPyAV-Org:mainfrom
Conversation
Author
|
Looks like this change is not needed and setting it like it's done for other video encoders does actually work (via Output Stream options dict)
@WyattBlue Feel free to close this MR if you think there is no need for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was trying to use QSV encoders but noticed that the property they use for quality-based mode is unavailable. This PR exposes it in PyAV.
Couldn't think of a useful test for this as QSV wouldn't be available in CI and i'm not aware of another video encoder that uses this (tested with libx264 but it's ignored).
Reference:
Example