fix: remove autoflake-inserted pass even when ignore_pass_statements=True - #349
Open
terminalchai wants to merge 1 commit into
Open
Conversation
…True When --ignore-pass-statements is set, autoflake was replacing removed imports with 'pass' (to keep block structure valid) but then leaving those passes in the output because the pass-removal step was skipped. Fix by threading an optional pass_sentinel argument through filter_code -> filter_unused_import -> filter_from_import / FilterMultilineImport. When fix_code calls these functions it passes _AUTOFLAKE_PASS_SENTINEL. filter_useless_pass then always removes lines tagged with that sentinel (if they are useless), but strips the sentinel comment from necessary passes (sole body of a block) before yielding them. Ref: PyCQA#206
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206
Problem
When --ignore-pass-statements is set, autoflake replaces removed imports with a temporary pass statement (needed to keep block structure valid while running pyflakes). Normally that pass is cleaned up by ilter_useless_pass, but with ignore_pass_statements=True the cleanup step is skipped entirely — leaving the autoflake-generated pass in the user's file.
`python
Input
import os
print('hello')
Expected output (with --ignore-pass-statements)
print('hello')
Actual output (bug)
pass
print('hello')
`
Fix
Thread an optional pass_sentinel parameter (default ) through: