Adding ThermoSci Assay plate #828
Open
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
could you please allow edits by maintainers? |
Comment on lines
+457
to
+458
| cross_section_type=CrossSectionType.CIRCLE, # circle wells | ||
| material_z_thickness=1.15, # from spec |
Member
There was a problem hiding this comment.
Suggested change
| cross_section_type=CrossSectionType.CIRCLE, # circle wells | |
| material_z_thickness=1.15, # from spec | |
| material_z_thickness=2.2, # from spec |
I think this should be 2.2 (measurement P)
Comment on lines
+470
to
+471
| model="Thermo_TS_Nunc_96_assay_300uL_Fb_Lid", | ||
| # raise NotImplementedError("This lid is not currently defined.") |
Member
There was a problem hiding this comment.
Suggested change
| model="Thermo_TS_Nunc_96_assay_300uL_Fb_Lid", | |
| # raise NotImplementedError("This lid is not currently defined.") | |
| model="Thermo_TS_Nunc_96_assay_300uL_Fb_Lid", |
Member
|
thanks for adding more plates! these are my two suggestions for this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added definition for Thermo Nunc assay plate for plate reader: Thermo Scientific™ Nunc™ 96-Well Optical-Bottom Microplate, black, TC surface
Basic clear bottom assay plate for plate reader experiments - we use these for 96w growth curve assays and fluorescent measurements