Add size parameter to USB read methods #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow specifying a maximum number of bytes to read via the `size` parameter on `read()` and `_read_packet()`. This is useful for protocols that need to read a specific number of bytes rather than reading until no more packets arrive. Also fix decode calls to use errors="backslashreplace" for robustness with binary data. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rickwierenga
force-pushed
the
usb-sized-read
branch
from
9c3e895 to
b42ef5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sizeparameter toUSB.read()andUSB._read_packet()to allow reading a specific number of byteserrors="backslashreplace"for robustness with binary dataUSBValidatorto support the newsizeparameterExtracted from #797 (Tecan Infinite plate reader backend).
Test plan
🤖 Generated with Claude Code