Open
Conversation
Collaborator
|
Is there a special reason why you delete the daq_2Dviewer_BaslerWithLECO.py file? For the rest of the PR, someone else has to take a look. |
Contributor
Author
|
Hello @BenediktBurger I made the judgement that the way that it was written was a bit too specific to the needs of our lab group and the way we were using LECO in our global DAQ scheme. I would like to include it again, but it should be rewritten so as to be generalized first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My colleague pointed out a bug regarding the new pop-up window for the creation of default config files. If you had never created a config file, and you create a dashboard preset with a Basler set up to auto-initialize, then PyMoDAQ will hang with just the logo showing. It turns out the pop-up window was being hidden behind the PyMoDAQ logo.
This was easily fixed in Windows by adding the appropriate flag for the window to be "top-most." In Linux, this is another issue. Any attempt in dealing with this behavior would regularly lead to segfaults. It seems to be a conflict with the re-painting of the PyMoDAQ logo during the dashboard initialization and the pop-up window, which is blocking. In fact, it is because we are creating this window from a non-GUI thread. This is tolerated in Windows since the pop-up creation does not touch Qt. However, there is no straightforward solution to this issue at the plugin level for Linux. Therefore, I opted to have the config file created by default if none exists for Linux users, with no pop-up windows.
Let me know what you guys think.