Fix stable ABI guidance to match pyo3/maturin#3226#453
Merged
Conversation
Contributor
Author
|
Also sorry for not being careful about this on the first pass! I manually verified the guidance in here using a version of Maturin with #3226 applied. |
Contributor
Author
|
I tried fixing CI by bumping the Python version and have now hit |
Member
|
That's rust-cross/cargo-zigbuild#452, I'll release new version and bump it in maturin later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #368
Fixes the README guidance to match PyO3/maturin#3226 and the reality of how this currently works in maturin, with only one stable abi wheel per build.
Also adds an explicit suggestion to build a cp314t wheel for projects building stable ABI wheels and abi3t wheels.