fix maturin build --pgo -i <version> with uv install#3237
Open
davidhewitt wants to merge 2 commits into
Open
Conversation
davidhewitt
changed the title
maturin build --pgo -i <version> with uv install
messense
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhat related to #3236
When using the
--pgoargument tomaturin build, if the interpreter is passed as e.g.-i 3.14and a python 3.14 interpreter is not found on the path by maturin, thenuvwas being invoked to create a virtual environment with argument--python ''(i.e. empty).This PR corrects this to forward a compatible version string to
uv.I also added a general integration test for PGO (however it doesn't specifically exercise this path, as passing a version to uv might force a download and it seemed fiddly to handle that in CI), and unit tests for the version strings passed to uv.