Merged
Conversation
davidhewitt
force-pushed
the
build-script-refactor
branch
from
e39060f to
fe9ed5c
Compare
Member
Author
|
CI failure looks like rust-lang/rust#84502 - I think we may have to live with coverage job being down for the next few days... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of a few small refactorings to
build.rs:BuildFlagsstruct inside theInterpreterConfig, which I think is logically correct.abi3_without_interpreterconfiguration now uses the same code path to emit cargo configuration as the rest of the script. This is motivated by changes in Add support for arbitrary arrays #1128 where I noticed theconfigure_const_generics()call was nearly missed out of theabi3_without_interpreterfunction, which would have led to confusing bugs.