Don't use intocallback in method macros

[mejrs]

This makes the errors much nicer.

[davidhewitt]

Thanks! I guess this goes in "changed" section of changelog?

There's similar for the proto methods, do you think we can use a similar approach?

[mejrs]

There's similar for the proto methods, do you think we can use a similar approach?

Can users still call any callback trait since pyproto was removed?

Also..ugh

  = help: the following other types implement trait `IntoPy<T>`:
            <&'a OsString as IntoPy<Py<PyAny>>>
            <&'a Path as IntoPy<Py<PyAny>>>
            <&'a PathBuf as IntoPy<Py<PyAny>>>
            <&'a PyErr as IntoPy<Py<PyAny>>>
            <&'a String as IntoPy<Py<PyAny>>>
            <&'a [u8] as IntoPy<Py<PyAny>>>
            <&'a str as IntoPy<Py<PyAny>>>
            <&'a str as IntoPy<Py<PyString>>>
          and 172 others

How do we deal with this in CI again? These counts change depending on the features 😭

I have filed rust-lang/rust#102752 which should do away both with the horrible error message and the "and ... others" thing, so these errors should get even better :)

[mejrs]

Okay, I think this works.

[mejrs]

Ah, I have a better idea,

[davidhewitt]

Thanks, this is looking really good! Sorry for my extended delay on reply, my son and I have been ill over the weekend previous and I'm finally better and catching up with things.

Can users still call any callback trait since pyproto was removed?

So eventually I would like to remove src/callback.rs and put everything in it into impl_ details. Users shouldn't be using that stuff directly as far as I'm concerned.

For the __dunder__ methods, the generated code is built up in pieces (because it needed to be flexible to support the variety of forms those dunders take).

The last uses of callback::convert which might be doing ok-wrapping are here and here.

If you want, we could save those for a separate PR?

[davidhewitt]

Aha nice find!

[mejrs]

Not a find, I made it 😉

[mejrs]

Thanks, this is looking really good! Sorry for my extended delay on reply, my son and I have been ill over the weekend previous and I'm finally better and catching up with things.

Get well soon 👍

If you want, we could save those for a separate PR?

I think that's be a good idea

[davidhewitt]

Cool, in which case let's merge this 👍

Get well soon 👍

Thanks, I'm fine now but my son still getting over it.