Fix synchronization of datetime tests#867
Merged
kngwyu merged 3 commits intoPyO3:masterfrom Apr 11, 2020
Merged
Conversation
Member
Author
|
I can still see an odd error 🤔 |
davidhewitt
reviewed
Apr 11, 2020
tests/test_datetime.rs
Outdated
| }; | ||
| } | ||
| // TODO(kngwyu): Remove this variable | ||
| const MUTEX: RawMutex = RawMutex::INIT; |
Member
There was a problem hiding this comment.
I think a const is actually not a real variable until the location it's used, so this still creates multiple copies of the mutex.
I think that the suggestion to use static on Travis is correct, as then there will only be one shared mutex:
Suggested change
| const MUTEX: RawMutex = RawMutex::INIT; | |
| static Mutex: RawMutex = RawMutex::INIT; |
kngwyu
force-pushed
the
datetime-test-fix-try2
branch
from
e70ed61 to
145b917
Compare
Member
|
Looks like something weird has happened to travis again. I wonder if we should be migrating to github actions to simplify the CI? |
davidhewitt
approved these changes
Apr 11, 2020
Member
Author
No worry, it was because of a bug. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by @programmerjake by this comment, the
lock!macro used in the datetime tests doesn't work.This PR
and
nighlyfeature from parking_lot@davidhewitt
I'm sorry that this PR conflicts with #866. I wanted to fix my fault myself.