Skip to content

try build emscripten without flags #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidhewitt wants to merge 3 commits into
base: main
Choose a base branch
from
+21 −108
Open

try build emscripten without flags #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13a62a3
try build emscripten without flags
davidhewitt Feb 4, 2026
b9d90de
Merge branch 'main' into emscripten-no-args
davidhewitt Feb 9, 2026
5de68e7
try both stable & nightly
davidhewitt Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 21 additions & 102 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,87 +66,28 @@ jobs:
# If one platform fails, allow the rest to keep testing if `CI-no-fail-fast` label is present
fail-fast: ${{ !contains(github.event.pull_request.labels.*.name, 'CI-no-fail-fast') }}
matrix:
python-version:
[
"3.9",
"3.10",
"3.11",
"3.14",
"3.13",
"3.13t",
"3.14",
"3.14t",
"pypy-3.11",
"graalpy25.0",
]
platform:
[
{
os: "macos-latest",
python-architecture: "arm64",
rust-target: "aarch64-apple-darwin",
},
{
os: "ubuntu-latest",
python-architecture: "x64",
rust-target: "x86_64-unknown-linux-gnu",
},
{
os: "windows-latest",
python-architecture: "x64",
rust-target: "x86_64-pc-windows-msvc",
},
]
python-version: ["3.9", "3.10", "3.11", "3.14", "3.13", "3.13t", "3.14", "3.14t", "pypy-3.11", "graalpy25.0"]
platform: [{os: "macos-latest", python-architecture: "arm64", rust-target: "aarch64-apple-darwin"}, {os: "ubuntu-latest", python-architecture: "x64", rust-target: "x86_64-unknown-linux-gnu"}, {os: "windows-latest", python-architecture: "x64", rust-target: "x86_64-pc-windows-msvc"}]
include:
# Just test one x86 Windows Python for simplicity
- python-version: "3.x"
platform:
{
os: "windows-latest",
python-architecture: "x86",
rust-target: "i686-pc-windows-msvc",
}
platform: {os: "windows-latest", python-architecture: "x86", rust-target: "i686-pc-windows-msvc"}
# Just test one arm64 Windows Python for simplicity
- python-version: "3.x"
platform:
{
os: "windows-11-arm",
python-architecture: "arm64",
rust-target: "aarch64-pc-windows-msvc",
}
platform: {os: "windows-11-arm", python-architecture: "arm64", rust-target: "aarch64-pc-windows-msvc"}
# Just test one x64 macOS Python for simplicity
- python-version: "3.x"
platform:
{
os: "macos-15-intel",
python-architecture: "x64",
rust-target: "x86_64-apple-darwin",
}
platform: {os: "macos-15-intel", python-architecture: "x64", rust-target: "x86_64-apple-darwin"}
# Just test one arm64 Ubuntu Python for simplicity
- python-version: "3.x"
platform:
{
os: "ubuntu-24.04-arm",
python-architecture: "arm64",
rust-target: "aarch64-unknown-linux-gnu",
}
platform: {os: "ubuntu-24.04-arm", python-architecture: "arm64", rust-target: "aarch64-unknown-linux-gnu"}
exclude:
# macOS arm doesn't have Python builds before 3.10
- python-version: 3.9
platform:
{
os: "macos-latest",
python-architecture: "arm64",
rust-target: "aarch64-apple-darwin",
}
platform: {os: "macos-latest", python-architecture: "arm64", rust-target: "aarch64-apple-darwin"}
# no graalpy available on Windows
- python-version: graalpy25.0
platform:
{
os: "windows-latest",
python-architecture: "x64",
rust-target: "x86_64-pc-windows-msvc",
}
platform: {os: "windows-latest", python-architecture: "x64", rust-target: "x86_64-pc-windows-msvc"}

env:
SETUPTOOLS_RUST_CARGO_PROFILE: dev
Expand Down Expand Up @@ -206,15 +147,7 @@ jobs:
# If one platform fails, allow the rest to keep testing if `CI-no-fail-fast` label is present
fail-fast: ${{ !contains(github.event.pull_request.labels.*.name, 'CI-no-fail-fast') }}
matrix:
os:
[
ubuntu-latest,
macos-latest,
windows-latest,
windows-11-arm,
macos-15-intel,
ubuntu-24.04-arm,
]
os: [ubuntu-latest, macos-latest, windows-latest, windows-11-arm, macos-15-intel, ubuntu-24.04-arm]
steps:
- uses: actions/checkout@v6
- name: Setup python
Expand Down Expand Up @@ -271,7 +204,7 @@ jobs:
# If one platform fails, allow the rest to keep testing if `CI-no-fail-fast` label is present
fail-fast: ${{ !contains(github.event.pull_request.labels.*.name, 'CI-no-fail-fast') }}
matrix:
platform: [{ arch: "aarch64" }, { arch: "armv7" }]
platform: [{arch: "aarch64"}, {arch: "armv7"}]
steps:
- uses: actions/checkout@v6
- name: Set up Python
Expand Down Expand Up @@ -359,9 +292,7 @@ jobs:
env:
CIBW_BUILD: cp39-*
CIBW_BEFORE_BUILD: >
pip install -U 'pip>=23.2.1' 'setuptools>=70.1.0' 'auditwheel>=5.4.0'
&& pip install -e .
&& pip list
pip install -U 'pip>=23.2.1' 'setuptools>=70.1.0' 'auditwheel>=5.4.0' && pip install -e . && pip list
CIBW_ARCHS_MACOS: "x86_64 universal2 arm64"
CIBW_BUILD_VERBOSITY: 3
CIBW_BUILD_FRONTEND: "build; args: --no-isolation"
Expand All @@ -375,21 +306,7 @@ jobs:
strategy:
fail-fast: false
matrix:
include:
[
{
msystem: MINGW64,
arch: x86_64,
path: mingw64,
rust_target: x86_64-pc-windows-gnu,
},
{
msystem: MINGW32,
arch: i686,
path: mingw32,
rust_target: i686-pc-windows-gnu,
},
]
include: [{msystem: MINGW64, arch: x86_64, path: mingw64, rust_target: x86_64-pc-windows-gnu}, {msystem: MINGW32, arch: i686, path: mingw32, rust_target: i686-pc-windows-gnu}]
steps:
- uses: actions/checkout@v6
- name: Install MSys2 and dependencies
Expand All @@ -398,12 +315,7 @@ jobs:
update: true
msystem: ${{ matrix.msystem }}
install: >-
git
mingw-w64-${{ matrix.arch }}-python
mingw-w64-${{ matrix.arch }}-python-pip
mingw-w64-${{ matrix.arch }}-openssl
mingw-w64-${{ matrix.arch }}-toolchain

git mingw-w64-${{ matrix.arch }}-python mingw-w64-${{ matrix.arch }}-python-pip mingw-w64-${{ matrix.arch }}-openssl mingw-w64-${{ matrix.arch }}-toolchain #magic___^_^___line
- uses: dtolnay/rust-toolchain@master
with:
toolchain: stable-${{ matrix.rust_target }}
Expand All @@ -423,7 +335,13 @@ jobs:
run: PATH="$PATH:/c/Users/runneradmin/.cargo/bin" nox -s test-examples

test-emscripten:
name: emscripten (${{ matrix.rust-version }} Rust)
strategy:
fail-fast: true
matrix:
rust-version: [stable, nightly]
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.rust-version == 'nightly' }}
steps:
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@v7
Expand All @@ -433,8 +351,9 @@ jobs:
- run: |
uvx nox -s install-pyodide-emscripten
echo "ORIG_PATH=$PATH" >> $GITHUB_ENV
- uses: dtolnay/rust-toolchain@nightly
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ matrix.rust-version }}
components: rust-src
targets: wasm32-unknown-emscripten
- uses: mymindstorm/setup-emsdk@v14
Expand Down
6 changes: 0 additions & 6 deletions setuptools_rust/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,6 @@ def build_extension(
# the cdylib, see https://github.com/rust-lang/cargo/issues/10143
rustflags.append("-Ctarget-feature=-crt-static")

elif (rustc_cfgs.get("target_arch"), rustc_cfgs.get("target_os")) == (
"wasm32",
"emscripten",
):
rustc_args.extend(["-C", "link-args=-sSIDE_MODULE=2 -sWASM_BIGINT"])

if use_cargo_crate_type and "--crate-type" not in cargo_args:
cargo_args.extend(["--crate-type", "cdylib"])

Expand Down
Loading