Skip to content

feat: Add DataTransformers and update benchmarking and tests#83

Open
iraedeus wants to merge 8 commits intoprototypefrom
iraedeus/dimension-problem
Open

feat: Add DataTransformers and update benchmarking and tests#83
iraedeus wants to merge 8 commits intoprototypefrom
iraedeus/dimension-problem

Conversation

@iraedeus
Copy link
Copy Markdown
Contributor

This pull request refactors the benchmarking infrastructure to use a new AlgorithmEntry data class for passing algorithm configurations, thresholds, and optional data transformers throughout the benchmarking codebase. This change improves code clarity, extensibility, and maintainability by standardizing how algorithm-related parameters are grouped and passed. The update affects the main benchmarking runners, the executor, and related documentation.

Key changes include:

Core API and Data Structure Refactor:

  • Replaced all usages of (algorithm, thresholds) tuples with AlgorithmEntry objects in NoResetBenchmarkRunner, ARLBenchmarkRunner, and BenchmarkExecutor, including their constructors, internal methods, and documentation. This standardizes how algorithms, thresholds, and optional transformers are handled and passed between components. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]

Documentation and Parameter Naming:

  • Updated docstrings and parameter names in all affected classes and methods to reference entries (of type AlgorithmEntry) instead of algorithms (tuples), clarifying their purpose and improving documentation accuracy. [1] [2] [3] [4] [5] [6]

Example and Usage Updates:

  • Updated example scripts (e.g., examples/noreset_shewhart.py) to use AlgorithmEntry when constructing benchmark runners, ensuring compatibility with the new API. [1] [2] [3] [4]

Minor/Other:

  • Changed the __author__ field in benchmark_logger.py to "Danil Totmyanin".

Overall, this refactor lays the groundwork for more flexible benchmark configuration and easier future extensions.

@iraedeus iraedeus requested a review from Desiment April 18, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant