feat: Add DataTransformers and update benchmarking and tests#83
Open
feat: Add DataTransformers and update benchmarking and tests#83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the benchmarking infrastructure to use a new
AlgorithmEntrydata class for passing algorithm configurations, thresholds, and optional data transformers throughout the benchmarking codebase. This change improves code clarity, extensibility, and maintainability by standardizing how algorithm-related parameters are grouped and passed. The update affects the main benchmarking runners, the executor, and related documentation.Key changes include:
Core API and Data Structure Refactor:
(algorithm, thresholds)tuples withAlgorithmEntryobjects inNoResetBenchmarkRunner,ARLBenchmarkRunner, andBenchmarkExecutor, including their constructors, internal methods, and documentation. This standardizes how algorithms, thresholds, and optional transformers are handled and passed between components. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]Documentation and Parameter Naming:
entries(of typeAlgorithmEntry) instead ofalgorithms(tuples), clarifying their purpose and improving documentation accuracy. [1] [2] [3] [4] [5] [6]Example and Usage Updates:
examples/noreset_shewhart.py) to useAlgorithmEntrywhen constructing benchmark runners, ensuring compatibility with the new API. [1] [2] [3] [4]Minor/Other:
__author__field inbenchmark_logger.pyto "Danil Totmyanin".Overall, this refactor lays the groundwork for more flexible benchmark configuration and easier future extensions.