Skip to content

fix: expose SCHED_FAILED #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tazend merged 1 commit into from
Mar 21, 2026
+12 −2
Merged

fix: expose SCHED_FAILED #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyslurm/core/reservation.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,6 @@ cdef class Reservation:
self.info.flags = flag.value
self.umsg.flags = flag._get_flags_cleared()

# TODO: RESERVE_FLAG_SKIP ?


class ReservationFlags(SlurmFlag):
"""Flags for Reservations that can be set.
Expand All @@ -534,6 +532,8 @@ class ReservationFlags(SlurmFlag):
NO_JOB_HOLD_AFTER_END = slurm.RESERVE_FLAG_NO_HOLD_JOBS
OVERLAP = slurm.RESERVE_FLAG_OVERLAP
ALL_NODES = slurm.RESERVE_FLAG_ALL_NODES
SKIP = slurm.RESERVE_FLAG_SKIP
SCHED_FAILED = slurm.RESERVE_FLAG_SCHED_FAILED


class ReservationReoccurrence(SlurmEnum):
Expand Down
10 changes: 10 additions & 0 deletions tests/unit/test_reservation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,13 @@ def test_create_instance():
assert resv.flags == ReservationFlags.FLEX | ReservationFlags.PURGE


def test_flags_sched_failed():
combo = (
ReservationFlags.SCHED_FAILED
| ReservationFlags.SPECIFIC_NODES
| ReservationFlags.IGNORE_RUNNING_JOBS
)
decoded = ReservationFlags(combo.value)
assert ReservationFlags.SCHED_FAILED in decoded