Skip to content

feat: update github workflows#407

Merged
giovtorres merged 1 commit intomainfrom
pypi-publish
Apr 1, 2026
Merged

feat: update github workflows#407
giovtorres merged 1 commit intomainfrom
pypi-publish

Conversation

@giovtorres
Copy link
Copy Markdown
Member

  • Added build-sdist CI job that builds and uploads the sdist artifact
  • Added build_rpm.sh script and build-rpm CI job that builds, installs, and exercises the RPM spec file
  • Added publish CI job that downloads the pre-built sdist artifact and publishes it to PyPI via Trusted Publishing
    (OIDC) on release.
  • Updated pyslurm.spec to use modern %pyproject_* macros, drop the hardcoded Python version, and fix the license
    identifier from GPLv2+ to GPL-2.0-only.
  • Updated docker-compose.yml to read the container image tag from SLURM_DOCKER_IMAGE so the workflow and compose file stay in sync.
  • Updated README.md to document PyPI installation as the primary method and add a version compatibility table.

@giovtorres giovtorres self-assigned this Mar 22, 2026
@giovtorres giovtorres force-pushed the pypi-publish branch 3 times, most recently from 9b483b2 to 1237cee Compare March 23, 2026 00:47
@giovtorres
Copy link
Copy Markdown
Member Author

@tazend What are your thoughts on this change?

@tazend
Copy link
Copy Markdown
Member

tazend commented Mar 29, 2026

@giovtorres Looks good, and I think its nice to finally have up2date releases on PyPi again :) Thank you 👍

Comment thread pyproject.toml

[tool.setuptools.packages.find]
include = ["pyslurm*"]
exclude = ["pyslurm.pydefines", "pyslurm.slurm"]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know when using scripts/build.sh setuptools was always complaining about those. Adding pyslurm.slurm here should still include it in the sdist though right? (since its explicitly mentioned in MANIFEST.in). It just doesn't add those sources to the final installation dir I guess? (which is fine)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, both of these directories don’t have an __init__.py and only have Cython source files. The sdist does include these files since they are part of the source files needed to build the extension. The exclude here is so that these dirs don’t show up as importable Python packages, but they don’t have an __init__.py anyway. So, this shouldn’t change behavior, just make it explicit, if i’m not mistaken.

→ tar tzvf dist/pyslurm-25.11.0.tar.gz | grep pxi
-rw-r--r--  0 root   root       19 Feb 27  2022 pyslurm-25.11.0/pyslurm/bluegene.pxi
-rw-r--r--  0 root   root    16959 Mar 15 16:55 pyslurm-25.11.0/pyslurm/pydefines/slurm_defines.pxi
-rw-r--r--  0 root   root    22903 Mar 15 16:55 pyslurm-25.11.0/pyslurm/pydefines/slurm_enums.pxi
-rw-r--r--  0 root   root      116 Nov 14  2021 pyslurm-25.11.0/pyslurm/pydefines/slurm_errno_defines.pxi
-rw-r--r--  0 root   root    10772 Mar 15 16:55 pyslurm-25.11.0/pyslurm/pydefines/slurm_errno_enums.pxi
-rw-r--r--  0 root   root     2729 Mar 15 16:55 pyslurm-25.11.0/pyslurm/pydefines/slurmdb_defines.pxi
-rw-r--r--  0 root   root     4411 Mar 15 16:55 pyslurm-25.11.0/pyslurm/pydefines/slurmdb_enums.pxi
-rw-r--r--  0 root   root    10507 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/extra.pxi
-rw-r--r--  0 root   root     3351 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/helpers.pxi
-rw-r--r--  0 root   root    91453 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/slurm.h.pxi
-rw-r--r--  0 root   root    15320 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/slurm_errno.h.pxi
-rw-r--r--  0 root   root      842 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/slurm_version.h.pxi
-rw-r--r--  0 root   root    38974 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/slurmdb.h.pxi

@giovtorres giovtorres marked this pull request as ready for review March 29, 2026 22:21
@giovtorres giovtorres merged commit d37ee40 into main Apr 1, 2026
5 checks passed
@giovtorres giovtorres deleted the pypi-publish branch April 1, 2026 19:58
@giovtorres giovtorres mentioned this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants