Conversation
9b483b2 to
1237cee
Compare
1237cee to
dc498ee
Compare
|
@tazend What are your thoughts on this change? |
|
@giovtorres Looks good, and I think its nice to finally have up2date releases on PyPi again :) Thank you 👍 |
|
|
||
| [tool.setuptools.packages.find] | ||
| include = ["pyslurm*"] | ||
| exclude = ["pyslurm.pydefines", "pyslurm.slurm"] |
There was a problem hiding this comment.
I know when using scripts/build.sh setuptools was always complaining about those. Adding pyslurm.slurm here should still include it in the sdist though right? (since its explicitly mentioned in MANIFEST.in). It just doesn't add those sources to the final installation dir I guess? (which is fine)
There was a problem hiding this comment.
Yeah, both of these directories don’t have an __init__.py and only have Cython source files. The sdist does include these files since they are part of the source files needed to build the extension. The exclude here is so that these dirs don’t show up as importable Python packages, but they don’t have an __init__.py anyway. So, this shouldn’t change behavior, just make it explicit, if i’m not mistaken.
→ tar tzvf dist/pyslurm-25.11.0.tar.gz | grep pxi
-rw-r--r-- 0 root root 19 Feb 27 2022 pyslurm-25.11.0/pyslurm/bluegene.pxi
-rw-r--r-- 0 root root 16959 Mar 15 16:55 pyslurm-25.11.0/pyslurm/pydefines/slurm_defines.pxi
-rw-r--r-- 0 root root 22903 Mar 15 16:55 pyslurm-25.11.0/pyslurm/pydefines/slurm_enums.pxi
-rw-r--r-- 0 root root 116 Nov 14 2021 pyslurm-25.11.0/pyslurm/pydefines/slurm_errno_defines.pxi
-rw-r--r-- 0 root root 10772 Mar 15 16:55 pyslurm-25.11.0/pyslurm/pydefines/slurm_errno_enums.pxi
-rw-r--r-- 0 root root 2729 Mar 15 16:55 pyslurm-25.11.0/pyslurm/pydefines/slurmdb_defines.pxi
-rw-r--r-- 0 root root 4411 Mar 15 16:55 pyslurm-25.11.0/pyslurm/pydefines/slurmdb_enums.pxi
-rw-r--r-- 0 root root 10507 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/extra.pxi
-rw-r--r-- 0 root root 3351 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/helpers.pxi
-rw-r--r-- 0 root root 91453 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/slurm.h.pxi
-rw-r--r-- 0 root root 15320 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/slurm_errno.h.pxi
-rw-r--r-- 0 root root 842 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/slurm_version.h.pxi
-rw-r--r-- 0 root root 38974 Mar 15 16:55 pyslurm-25.11.0/pyslurm/slurm/slurmdb.h.pxi
(OIDC) on release.
identifier from GPLv2+ to GPL-2.0-only.