Add unittest suite and GitHub Actions CI workflow#10
Merged
Conversation
Agent-Logs-Url: https://github.com/PyThaiNLP/LEKCut/sessions/6266cef0-f9f2-420d-abda-2c42afcb0a4a Co-authored-by: wannaphong <8536487+wannaphong@users.noreply.github.com>
…sefr empty-string tests, add workflow permissions Agent-Logs-Url: https://github.com/PyThaiNLP/LEKCut/sessions/6266cef0-f9f2-420d-abda-2c42afcb0a4a Co-authored-by: wannaphong <8536487+wannaphong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unittest and GitHub Action for testing
Add unittest suite and GitHub Actions CI workflow
Apr 7, 2026
wannaphong
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No test infrastructure existed for the LEKCut library. This adds a full
unittestsuite covering every supported model and a CI workflow to run it automatically.Tests (
tests/test_lekcut.py)25 tests across all seven tokenizer models (
deepcut,attacut-sc,attacut-c,oskut,sefr-ws1000,sefr-tnhc,sefr-best), each covering:[]NotImplementedErrorraised for unknown model namesCI (
.github/workflows/tests.yml)Runs
python -m unittest discover -s tests -von push/PR tomainacross Python 3.9–3.12, withpermissions: contents: read.Bug fixes
deepcut.pyandattacut.pylacked the empty-string guard already present inoskut.py, causing an ONNX runtime crash on empty input. Addedif not text: return []to theirtokenizemethods.