fix: guard nighit, check_sara, check_marttra against empty input#1377
Conversation
nighit() crashed with IndexError when w2 had no consonants.
check_sara("") and check_marttra("") crashed accessing word[-1].
Add input validation with clear error messages.
There was a problem hiding this comment.
Pull request overview
Guards three Thai-language public helpers (KhaveeVerifier.check_sara, KhaveeVerifier.check_marttra, and morpheme.nighit) against previously crashing edge-cases (empty input / no-consonant input), addressing issue #1376.
Changes:
- Add early empty-input returns to
check_saraandcheck_marttra. - Make
nighitraise aValueErrorwhenw2contains no Thai consonants (instead of crashing).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
pythainlp/morpheme/word_formation.py |
Adds a safe guard for nighit() when w2 has no Thai consonants. |
pythainlp/khavee/core.py |
Adds empty-input guards to avoid IndexError in check_sara() and check_marttra(). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
|
This PR is stale because it has been open for 30 days with no activity. |
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Coverage is 66.643% — phoneee:fix/empty-string-guards into PyThaiNLP:dev. No base build found for |
Added type checks and string handling for inputs.
|
PR #1377 adds guardrails to nighit(). This PR add tests to those guardrails. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
What do these changes do
Fix
check_sara,check_marttra, andnighitcrashing on empty string or vowel-only inputFixes #1376