Merged
Conversation
👷 Deploy request for pyconug pending review.Visit the deploys page to approve it
|
| import { QUICKET_LINK } from "@/2023/utils/constants"; | ||
| import { useState } from "react"; | ||
| import { useState, Fragment } from "react"; | ||
| import { Dialog, Disclosure, Popover, Transition } from "@headlessui/react"; |
Member
There was a problem hiding this comment.
hey @GeoXhacker , the redesign looks amazing...i really love it.
headlessui is great, its actually what we'd piloted with but, due to a couple of reasons not limited to the numbers of components they offer.... we are moving to radixui implemented with shadcn. For icon, we are settling for lucid icons .
it would really be amazing to have this navbar with the new approach we adopting moving forward in a fork off #131 as well. you can please check out what @amkayondo is working on via #131
really excited for us to have this implementation through #131 as well! Thanks a bunch, @GeoXhacker!
HassanBahati
approved these changes
May 20, 2024
Member
HassanBahati
left a comment
HassanBahati
left a comment
There was a problem hiding this comment.
LGTM! Thanks @GeoXhacker 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
This pull request addresses the redesign of the navigation bar (navbar) to improve the user interface and user experience. The updated design aims to provide a more intuitive and visually appealing navigation experience for our users.
Key Changes:
New Layout and Design:
Responsive Design:
Accessibility Improvements:
Enhanced Functionality:
Code Refactoring:
Packages
Please review and let me know if you'll need more adjustments to the navbar. Thanks