Open
Conversation
this is a mod of the original SRJV rom extraction code adapted to the internal roms
PythonBlue
reviewed
Jun 14, 2025
Owner
PythonBlue
left a comment
PythonBlue
left a comment
There was a problem hiding this comment.
This is a potential idea for sure, but I feel like it might get too confusing for people new to these tools by having multiple extraction scripts: ideally, I would implement an all-in-one approach, so permission is granted to edit the original scripts as needed to implement both sets of functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a mod of the original SRJV rom extraction code adapted to the internal roms