Skip to content

fix: improve button ratio calculation #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sietsev-q42 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve button ratio calculation #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/svelte/virtual/Embed.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,14 @@
scale = w/(embed.width / info.width) * htmlButtonEmbedScale * (is360 ? Math.PI/2 : 1);
buttonStyles.push(`width:${embed.width/htmlButtonEmbedScale}px`);
}

buttonStyles.push(`--ratio:${w/h * info.width/info.height};--scale:${scale}`);

const ratio = (embed.width ?? info.width) / (embed.height ?? info.height);

buttonStyles.push(`--ratio:${ratio};`);
buttonStyles.push(`--scale:${scale};`);

// Uncomment for debugging button placement - adds a visible outline to the button/image
// buttonStyles.push(`outline: 5px solid rgb(20 200 20 / 60%);`);

if(isSVG) buttonStyle+=`height:${embed.height}px`; // Set height directly for SVG

Expand Down