Fix Long Compilation Time for starknet_with_keccak Layout on Certain Machines#6
Open
hellojason3 wants to merge 4 commits intomainfrom
Open
Fix Long Compilation Time for starknet_with_keccak Layout on Certain Machines#6hellojason3 wants to merge 4 commits intomainfrom
hellojason3 wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the issue of excessively long compilation times for the
starknet_with_keccaklayout in the release build on certain machines. For instance, on an Intel 13900H, the compilation time was observed to be 259 minutes.Problem:
The exact cause of the issue is unclear, but it was found that reducing the number of clone operations in the
starknet_with_keccak/autogenerated.rsfile significantly decreases the compilation time.Here are some logs when we compiled.
Rust version: nightly-2024-09-17
Compilation time was measured using the command:
RUSTFLAGS="-Z time-passes" cargo build --release --features starknet_with_keccak --no-default-featuresBelow is the compilation log for the Intel 13900H:
Solution:
We have undertaken extensive work to reduce the number of clone operations. The results are significant, with the release build time now reduced to approximately 3 minutes.