feat: optimise for pederson hash#7
Open
hellojason3 wants to merge 1 commit intofeat/merge-compile-too-long-into-mainfrom
Open
feat: optimise for pederson hash#7hellojason3 wants to merge 1 commit intofeat/merge-compile-too-long-into-mainfrom
hellojason3 wants to merge 1 commit intofeat/merge-compile-too-long-into-mainfrom
Conversation
hellojason3
commented
Oct 14, 2024
| #[allow(clippy::needless_range_loop)] | ||
| for i in 0..256 { | ||
| let suffix = x.rsh(i); | ||
| //let suffix = x.rsh(i); |
Collaborator
Author
There was a problem hiding this comment.
This is where a lot of memory and time are consumed, so I changed the way to perform bit operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During testing, we observed that the line
let digest = self.public_input.get_hash();consumes approximately 60GB of memory and takes around 160 seconds to run. This performance needs optimization.Work Done
Analysis showed that most of the time is spent in the function
gen_element_steps_var, which takes about 150 seconds. We optimized it by:Result
The optimization was successful, reducing memory usage from 60GB to 3GB and execution time from 160 seconds to 27 seconds.