Skip to content

remove mode 0, cleanup, cpp11 compatible, 1 opcode per script, change to OP_CHECKZKPVERIFY, optimize bls12-381#4

Open
logere wants to merge 9 commits intoQEDProtocol:1.15.0-dev-groth16from
logere:1.15.0-dev-groth16
Open

remove mode 0, cleanup, cpp11 compatible, 1 opcode per script, change to OP_CHECKZKPVERIFY, optimize bls12-381#4
logere wants to merge 9 commits intoQEDProtocol:1.15.0-dev-groth16from
logere:1.15.0-dev-groth16

Conversation

@logere
Copy link
Copy Markdown
Collaborator

@logere logere commented Aug 28, 2024 •
edited
Loading

  1. cpp11 compatible
  2. passed all dogecoin github actions
  3. static check: cppcheck and codechecker checks ok
  4. runtime check: valgrind and sanitizer checks ok
  5. rm OP_CHECKGROTH16VERIFY mode 0
  6. add OP_CHECKGROTH16VERIFY script bench
  7. 1 opcode per script
  8. optimize non-asm code
  9. optimize deserializeVK and precomputeVK

@logere logere requested review from 0x8f701, cf and hellojason3 August 28, 2024 05:37
@logere logere force-pushed the 1.15.0-dev-groth16 branch from 194d479 to 004b4e4 Compare October 15, 2024 10:30
@logere logere changed the title cleanup, cpp11 and 32bit machine compatible remove mode 0, cleanup, cpp11 and 32bit machine compatible Oct 16, 2024
@logere logere changed the title remove mode 0, cleanup, cpp11 and 32bit machine compatible remove mode 0, add add OP_CHECKGROTH16VERIFY bench, cleanup, cpp11 and 32bit machine compatible Oct 21, 2024
@logere logere changed the title remove mode 0, add add OP_CHECKGROTH16VERIFY bench, cleanup, cpp11 and 32bit machine compatible remove mode 0, add OP_CHECKGROTH16VERIFY bench, cleanup, cpp11 and 32bit machine compatible Oct 21, 2024
@logere logere force-pushed the 1.15.0-dev-groth16 branch from 4587631 to af9eec1 Compare November 4, 2024 04:09
@logere logere force-pushed the 1.15.0-dev-groth16 branch from af9eec1 to 70243ea Compare November 4, 2024 08:04
@logere logere changed the title remove mode 0, add OP_CHECKGROTH16VERIFY bench, cleanup, cpp11 and 32bit machine compatible remove mode 0, add OP_CHECKGROTH16VERIFY bench, cleanup, cpp11 and 32bit machine compatible, 1 opcode per script, change to OP_CHECKZKPVERIFY Nov 4, 2024
@logere logere changed the title remove mode 0, add OP_CHECKGROTH16VERIFY bench, cleanup, cpp11 and 32bit machine compatible, 1 opcode per script, change to OP_CHECKZKPVERIFY remove mode 0, cleanup, cpp11 compatible, 1 opcode per script, change to OP_CHECKZKPVERIFY, optimize non-asm code Nov 4, 2024
@logere logere changed the title remove mode 0, cleanup, cpp11 compatible, 1 opcode per script, change to OP_CHECKZKPVERIFY, optimize non-asm code remove mode 0, cleanup, cpp11 compatible, 1 opcode per script, change to OP_CHECKZKPVERIFY, optimize bls12-381 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cf cf Awaiting requested review from cf

@0x8f701 0x8f701 Awaiting requested review from 0x8f701

@hellojason3 hellojason3 Awaiting requested review from hellojason3

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@logere