Refactor expression validation in nft_dynset.c#49
Closed
Mrcopytuo wants to merge 5 commits intoQQxiaoming:mainfrom
Closed
Refactor expression validation in nft_dynset.c#49Mrcopytuo wants to merge 5 commits intoQQxiaoming:mainfrom
Mrcopytuo wants to merge 5 commits intoQQxiaoming:mainfrom
Conversation
Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 7 to 8. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](dawidd6/action-download-artifact@v7...v8) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…tions/dawidd6/action-download-artifact-8
Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 8 to 9. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](dawidd6/action-download-artifact@v8...v9) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…tions/dawidd6/action-download-artifact-9
970e29e to
1a76280
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Linux kernel’s netfilter nftables subsystem had a null pointer dereference vulnerability in
nft_dynset_init()innet/netfilter/nft_dynset.cthat could be triggered when dynset expressions provided by userspace did not match the corresponding set expression parameters. This may allow a local attacker withCAP_NET_ADMINprivileges to cause a denial-of-service (kernel crash). This is tracked as CVE-2023-6622.Change Summary
net/netfilter/nft_dynset.c, add explicit checks to ensure that when dynset expression lengths differ from set expression lengths, the logic bails out early with an error (-EINVAL), avoiding use of mismatched pointers.References
3701cd390fd731ee7ae8b8006246c8db82c72bea