Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates extension versions to 2026.4.15, adds new tool display configurations for QVeris, and refactors several extensions for improved formatting and type safety. Critical feedback was provided regarding the accidental commitment of build artifacts and local node_modules binaries containing hardcoded absolute paths. Additionally, the reviewer suggested seeking more type-safe alternatives to the brittle type casting used in the Discord voice SDK integration.
| export NODE_PATH="/Users/linfangwang/Work/develop/qveris-ai/qverisbot/node_modules:/Users/linfangwang/Work/develop/qveris-ai/node_modules:/Users/linfangwang/Work/develop/node_modules:/Users/linfangwang/Work/node_modules:/Users/linfangwang/node_modules:/Users/node_modules:/node_modules:/Users/linfangwang/Work/develop/qveris-ai/qverisbot/node_modules/.pnpm/node_modules" | ||
| else | ||
| export NODE_PATH="/Users/linfangwang/Work/develop/qveris-ai/qverisbot/node_modules:/Users/linfangwang/Work/develop/qveris-ai/node_modules:/Users/linfangwang/Work/develop/node_modules:/Users/linfangwang/Work/node_modules:/Users/linfangwang/node_modules:/Users/node_modules:/node_modules:/Users/linfangwang/Work/develop/qveris-ai/qverisbot/node_modules/.pnpm/node_modules:$NODE_PATH" |
There was a problem hiding this comment.
This script contains hardcoded absolute paths ('/Users/linfangwang/...') that are specific to a local development environment. This makes the script non-portable and leaks sensitive local path information. Additionally, the node_modules directory should not be committed to the repository.
| export NODE_PATH="/Users/linfangwang/Work/develop/qveris-ai/qverisbot/node_modules:/Users/linfangwang/Work/develop/qveris-ai/node_modules:/Users/linfangwang/Work/develop/node_modules:/Users/linfangwang/Work/node_modules:/Users/linfangwang/node_modules:/Users/node_modules:/node_modules:/Users/linfangwang/Work/develop/qveris-ai/qverisbot/node_modules/.pnpm/node_modules" | ||
| else | ||
| export NODE_PATH="/Users/linfangwang/Work/develop/qveris-ai/qverisbot/node_modules:/Users/linfangwang/Work/develop/qveris-ai/node_modules:/Users/linfangwang/Work/develop/node_modules:/Users/linfangwang/Work/node_modules:/Users/linfangwang/node_modules:/Users/node_modules:/node_modules:/Users/linfangwang/Work/develop/qveris-ai/qverisbot/node_modules/.pnpm/node_modules:$NODE_PATH" |
There was a problem hiding this comment.
This script contains hardcoded absolute paths ('/Users/linfangwang/...') that are specific to a local development environment. This makes the script non-portable and leaks sensitive local path information. Additionally, the node_modules directory should not be committed to the repository.
| @@ -0,0 +1 @@ | |||
| 2026-04-17T06:22:31.880Z | |||
There was a problem hiding this comment.
Build artifacts like .boundary-tsc.stamp files should not be committed to the repository. These files are generated during the build process and should be excluded via .gitignore to avoid repository bloat and unnecessary merge conflicts.
| function resolveManualEndBehaviorType(voiceSdk: ReturnType<typeof loadDiscordVoiceSdk>): unknown { | ||
| return ( | ||
| (voiceSdk as unknown as { EndBehaviorType?: { Manual?: unknown } }).EndBehaviorType?.Manual ?? 0 | ||
| ); | ||
| } |
There was a problem hiding this comment.
The use of 'as unknown as' to access EndBehaviorType suggests that the types for the Discord voice SDK might be missing or incomplete in the current environment. While this works as a workaround, it is brittle. Consider if the SDK types can be updated or if a more type-safe way to check for these constants exists.
1 participant
Summary
pnpm checkgreen againmainare blocked by repository rulesVerification
env OPENCLAW_LOCAL_CHECK=0 pnpm checkNotes
mainso they can land through PR review:b8666457b4check: fix release-blocking lint issues8a536b87e9chore: sync remaining local changes