Skip to content

chore: land release follow-ups and test stabilization#123

Merged
linfangw merged 2 commits intomainfrom
linfangw-release-followups-2026-04-17
Apr 17, 2026
Merged

chore: land release follow-ups and test stabilization#123
linfangw merged 2 commits intomainfrom
linfangw-release-followups-2026-04-17

Conversation

@linfangw
Copy link
Copy Markdown
Collaborator

Summary

  • land the release follow-up fixes and remaining local changes on this branch
  • stabilize local full-suite Vitest scheduling for release validation on 48 GB hosts
  • move ACP-specific command coverage onto the ACP shard and refresh the generated config schema version

Verification

  • pnpm check
  • env OPENCLAW_LOCAL_CHECK=0 pnpm test

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reduces default Vitest parallelism and introduces a 64GB memory threshold for the large execution profile. It also disables the experimental filesystem module cache for parallel shards by default to mitigate stability issues and moves agent.acp.test.ts to the ACP test suite. A review comment identifies duplicated logic for parsing truthy environment variables and suggests moving it to a shared utility.

Comment on lines +668 to +671
function isTruthyEnvValue(value) {
const normalized = value?.trim().toLowerCase();
return normalized === "1" || normalized === "true";
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for checking truthy environment variable values is duplicated here and in scripts/lib/vitest-local-scheduling.mjs (within isSystemThrottleDisabled). Consider moving this to a shared utility function in scripts/lib/vitest-local-scheduling.mjs and exporting it to improve maintainability and consistency across the codebase.

@linfangw linfangw merged commit 3f66f05 into main Apr 17, 2026
2 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant