chore: land release follow-ups and test stabilization#123
Conversation
There was a problem hiding this comment.
Code Review
This pull request reduces default Vitest parallelism and introduces a 64GB memory threshold for the large execution profile. It also disables the experimental filesystem module cache for parallel shards by default to mitigate stability issues and moves agent.acp.test.ts to the ACP test suite. A review comment identifies duplicated logic for parsing truthy environment variables and suggests moving it to a shared utility.
| function isTruthyEnvValue(value) { | ||
| const normalized = value?.trim().toLowerCase(); | ||
| return normalized === "1" || normalized === "true"; | ||
| } |
There was a problem hiding this comment.
The logic for checking truthy environment variable values is duplicated here and in scripts/lib/vitest-local-scheduling.mjs (within isSystemThrottleDisabled). Consider moving this to a shared utility function in scripts/lib/vitest-local-scheduling.mjs and exporting it to improve maintainability and consistency across the codebase.
Summary
Verification
pnpm checkenv OPENCLAW_LOCAL_CHECK=0 pnpm test