Use function overloading to handle variations in strerror_r() impleme…#124
Open
dx9 wants to merge 1 commit intoQihoo360:masterfrom
Open
Use function overloading to handle variations in strerror_r() impleme…#124dx9 wants to merge 1 commit intoQihoo360:masterfrom
dx9 wants to merge 1 commit intoQihoo360:masterfrom
Conversation
Collaborator
|
Do you test on all platforms? MACOSX, windows, linux ? |
Contributor
Author
|
I've tested it on alpine (XSI), ubuntu (GNU), and OS X (XSI). I don't have windows. |
zieckey
reviewed
Jan 31, 2018
evpp/sockets.cc
Outdated
| return empty_string; | ||
| } | ||
| #else | ||
| std::string handle_strerror_r(char* s, char* buf) // GNU-specific |
Collaborator
There was a problem hiding this comment.
Change to const char* s is better.
…ntation. Avoids using macros or cmake to detect implementation. Inspired by http://zverovich.net/2015/03/13/reliable-detection-of-strerror-variants.html. Signed-off-by: John Coyle <dx9err@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
?