Add some notes about shots and precision#5249
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the following people are relevant to this code: |
| "Although precision specified in the PUB and in `run` have higher precedence, the job would fail if `twirling` is enabled and the product of `num_randomizations` and `shots_per_randomization` is smaller than the shots needed to achieve the precision. In this scenario `EstimatorV2` does not know how to allocate the shots among the specified `num_randomizations`.\n", | ||
| "</Admonition>\n", | ||
| "\n", | ||
| "<Admonition type=\"note\">\n", |
There was a problem hiding this comment.
Just confirming that you want two admonition boxes in a row - it's fine if intentional
There was a problem hiding this comment.
I kept them separate only because they refer to different things, but I don't feel too strongly either way. Do we usually use 1 box to group these together?
There was a problem hiding this comment.
If they are related enough, we can list them as bullet points in the same admonition - but I think it's fine to keep these as two admonitions, even one after the other like this, since it adds readability and emphasis, which I think you want here. I just wanted to be sure that was the intent.
Co-authored-by: abbycross <across@us.ibm.com>
3 participants
Per user feedback, this PR adds a note saying an error is raised if the primitive doesn't know how to divide shots among twirls when twirling is enabled.
Also closes #5082