Fix/qdn publishing check#34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#30:
Old-format migration now writes lastUpdated: 0 instead of Date.now(). Any valid QDN timestamp (> 0) will always be considered newer, so the startup sync fetches from QDN instead of publishing spuriously.
Before publishing when QDN returns null, the code now reads a q-wallets-addressbook-published-${coinType} sentinel key from localStorage. If the hash of local entries matches the last successfully published hash, the publish (and its permission dialog) is skipped. This prevents repeated proposals during QDN propagation delay.
publishToQDN now captures lastUpdated = Date.now() before the async operations and returns it (or null on failure). Both call-sites in the startup sync use the returned value to write localStorage, so local and QDN timestamps are identical after a publish — the next startup goes straight to the equal-timestamp path with no further hash comparison or dialog.
publishToQDN also writes the published hash to the sentinel key on every successful publish (startup or debounced), keeping the propagation-delay guard in sync.