Skip to content

Potential fix for code scanning alert no. 36: Log Injection #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zochory merged 1 commit into from
Oct 12, 2025
Merged

Potential fix for code scanning alert no. 36: Log Injection #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/agenticfleet/cli/repl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ async def run_repl() -> None:
if not user_input:
continue

logger.info(f"Processing: '{user_input}'")
safe_user_input = user_input.replace('\r', '').replace('\n', '')
Copy link

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more comprehensive sanitization approach. The current fix only removes \r and \n, but other control characters like \t (tab) could also be problematic for log parsing. Consider using user_input.replace('\r', '').replace('\n', '').replace('\t', ' ') or a regex approach to handle all control characters.

Copilot uses AI. Check for mistakes.
logger.info(f"Processing: '{safe_user_input}'")
print("-" * 50)

try:
Expand Down
Loading