Skip to content

merge main#509

Merged
Zochory merged 6 commits intomemory-fleet-devfrom
main
Dec 29, 2025
Merged

merge main#509
Zochory merged 6 commits intomemory-fleet-devfrom
main

Conversation

@Zochory
Copy link
Member

@Zochory Zochory commented Dec 29, 2025

This pull request removes two major documentation files describing the AgenticFleet architecture and updates GitHub Actions workflow files to use newer versions of key actions. The documentation removals eliminate both the overview and technical whitepaper for AgenticFleet, while the workflow changes upgrade the actions/checkout and actions/github-script actions to newer commit SHAs and versions.

The most important changes are:

Documentation Removal:

  • Deleted .fleet/AgenticFleet_Synthesis.md, which provided a high-level architectural overview, design philosophy, and integration details for AgenticFleet.
  • Deleted .fleet/technical.md, which contained the technical whitepaper outlining AgenticFleet's layered architecture, orchestration pipeline, and production principles.

GitHub Actions Workflow Updates:

  • Updated actions/checkout to a newer commit SHA (8e8c483db84b4bee98b60c0593521ed34d9990e8) in .github/workflows/ci-doctor.lock.yml, .github/workflows/docs-sync.aw.lock.yml, and .github/workflows/q.lock.yml to ensure the latest fixes and improvements are used. [1] [2] [3] [4] [5] [6]
  • Upgraded actions/github-script from v7.0.1 to v8.0.0 in the same workflow files, providing compatibility with the latest GitHub Actions APIs and features. [1] [2] [3] [4] [5]## Description

Zochory and others added 6 commits December 29, 2025 06:51
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>
Bumps [actions/github-script](https://github.com/actions/github-script) from 7.0.1 to 8.0.0.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v7.0.1...ed59741)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: 8.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zachary BENSALEM <zachary@qredence.ai>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5.0.1...8e8c483)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zachary BENSALEM <zachary@qredence.ai>
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>
Updates the requirements on [typer](https://github.com/fastapi/typer) to permit the latest version.
- [Release notes](https://github.com/fastapi/typer/releases)
- [Changelog](https://github.com/fastapi/typer/blob/master/docs/release-notes.md)
- [Commits](fastapi/typer@0.20.0...0.21.0)

---
updated-dependencies:
- dependency-name: typer
  dependency-version: 0.21.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zachary BENSALEM <zachary@qredence.ai>
@Zochory Zochory self-assigned this Dec 29, 2025
@github-project-automation github-project-automation bot moved this to Backlog in AgenticFleet Dec 29, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch main

Comment @coderabbitai help to get the list of available commands and usage tips.

@Zochory Zochory merged commit c59b61a into memory-fleet-dev Dec 29, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in AgenticFleet Dec 29, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Zochory, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on essential maintenance and cleanup tasks. It removes outdated architectural documentation for AgenticFleet, updates GitHub Actions workflows to leverage newer and more secure versions of critical actions, and enhances a core logging utility to ensure better sanitization of log entries. Additionally, a minor dependency version range for typer was adjusted.

Highlights

  • Documentation Removal: Two major documentation files, .fleet/AgenticFleet_Synthesis.md and .fleet/technical.md, which described the AgenticFleet architecture, have been deleted.
  • GitHub Actions Workflow Updates: The actions/checkout action has been updated to a newer commit SHA, and actions/github-script has been upgraded from v7.0.1 to v8.0.0 across several workflow files (ci-doctor.lock.yml, docs-sync.aw.lock.yml, q.lock.yml) for improved security and compatibility.
  • Dependency Version Update: The version constraint for the typer dependency in pyproject.toml has been updated to allow versions up to <0.22.0.
  • Logging Sanitization Enhancement: The sanitize_for_logging function in src/agentic_fleet/api/routes/observability.py has been improved to explicitly handle newline characters, restrict output to printable ASCII, and refine control character removal for more robust and secure logging.
Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/ci-doctor.lock.yml
    • .github/workflows/docs-sync.aw.lock.yml
    • .github/workflows/q.lock.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the typer dependency and refactors the sanitize_for_logging function. The dependency update is a minor version bump and seems fine. However, the refactoring of the sanitization function introduces several redundant and inefficient steps. I have provided a review comment with a suggested simplification to improve efficiency and maintainability.

Comment on lines +36 to 45
cleaned = text.replace("\r", " ").replace("\n", " ")
# Remove all control characters (0x00-0x1f includes CR, LF, tabs)
# and extended control characters (0x7f-0x9f).
cleaned = re.sub(r"[\x00-\x1f\x7f-\x9f]", " ", cleaned)
# Collapse runs of whitespace to a single space.
cleaned = re.sub(r"\s+", " ", cleaned).strip()
# Finally, drop any remaining characters outside a conservative safe set
# Restrict to printable ASCII characters only.
cleaned = re.sub(r"[^\x20-\x7e]", "", cleaned)
# Finally, drop any remaining characters outside a conservative safe set.
return re.sub(r"[^\w\-\.@:/ ]", "", cleaned)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This sequence of sanitization steps can be simplified for better efficiency and readability. Some steps are redundant:

  1. The initial replace("\r", " ").replace("\n", " ") is redundant because the subsequent re.sub(r"[\x00-\x1f\x7f-\x9f]", ...) already handles newline characters (\n is \x0a, \r is \x0d).
  2. The re.sub(r"[^\x20-\x7e]", ...) to remove non-printable ASCII is also redundant. The final whitelist [^\w\-\.@:/ ] only contains printable ASCII characters, so any non-printable characters would be removed by the final step anyway.

The implementation can be simplified to be more efficient, closer to its original version.

Suggested change
cleaned = text.replace("\r", " ").replace("\n", " ")
# Remove all control characters (0x00-0x1f includes CR, LF, tabs)
# and extended control characters (0x7f-0x9f).
cleaned = re.sub(r"[\x00-\x1f\x7f-\x9f]", " ", cleaned)
# Collapse runs of whitespace to a single space.
cleaned = re.sub(r"\s+", " ", cleaned).strip()
# Finally, drop any remaining characters outside a conservative safe set
# Restrict to printable ASCII characters only.
cleaned = re.sub(r"[^\x20-\x7e]", "", cleaned)
# Finally, drop any remaining characters outside a conservative safe set.
return re.sub(r"[^\w\-\.@:/ ]", "", cleaned)
# Remove all control characters (0x00-0x1f includes CR, LF, tabs)
# and extended control characters (0x7f-0x9f).
cleaned = re.sub(r"[\x00-\x1f\x7f-\x9f]", " ", text)
# Collapse runs of whitespace to a single space.
cleaned = re.sub(r"\s+", " ", cleaned).strip()
# Finally, drop any remaining characters outside a conservative safe set.
return re.sub(r"[^\w\-\.@:/ ]", "", cleaned)

Zochory added a commit that referenced this pull request Dec 29, 2025
* chore: Remove outdated documentation and style guides

- Deleted the technical whitepaper for AgenticFleet, which detailed the architecture and design principles.
- Removed general code style principles, Python style guide summary, TypeScript style guide summary, product guidelines, and product overview documents.
- Cleared out the tech stack documentation and project tracks, including metadata and plans for refactoring.
- Eliminated the setup state file and workflow documentation to streamline the repository.

* chore(memory): update .gitignore to track shared knowledge blocks

- Track core/project.md and core/persona.md (shared architecture & guidelines)
- Track blocks/ (shared topic knowledge)
- Track system/ (agent definitions like fleet-agent)
- Track skills/memory-system-guide.md (documentation)
- Keep ignored: human.md, skills/*.md, recall/**/*, .chroma/*, .neon/*

* feat: add documentation agent and related configurations

- Introduced a new configuration file `opencode.jsonc` for MCP context.
- Updated `pyproject.toml` to include `psycopg2-binary` as a dependency.
- Added `get_documentation_instructions` function in `prompts.py` for documentation agent.
- Configured the documentation agent in `workflow_config.yaml` with model, instructions, and capabilities.
- Updated `uv.lock` to include `psycopg2-binary` with version 2.9.11.

* merge main (#509)

* Potential fix for code scanning alert no. 172: Log Injection

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>

* chore(deps): bump actions/github-script from 7.0.1 to 8.0.0 (#501)

Bumps [actions/github-script](https://github.com/actions/github-script) from 7.0.1 to 8.0.0.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v7.0.1...ed59741)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: 8.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zachary BENSALEM <zachary@qredence.ai>

* chore(deps): bump actions/checkout from 5.0.1 to 6.0.1 (#499)

Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5.0.1...8e8c483)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zachary BENSALEM <zachary@qredence.ai>

* Delete .fleet/AgenticFleet_Synthesis.md

Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>

* Delete .fleet/technical.md

Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>

* chore(deps): update typer requirement (#503)

Updates the requirements on [typer](https://github.com/fastapi/typer) to permit the latest version.
- [Release notes](https://github.com/fastapi/typer/releases)
- [Changelog](https://github.com/fastapi/typer/blob/master/docs/release-notes.md)
- [Commits](fastapi/typer@0.20.0...0.21.0)

---
updated-dependencies:
- dependency-name: typer
  dependency-version: 0.21.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zachary BENSALEM <zachary@qredence.ai>

---------

Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: update typer dependency version range to allow for newer releases

* Potential fix for pull request finding 'Empty except'

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>

* fix: replace hardcoded CONTEXT7_API_KEY with environment variable

* Update .claude/skills/feature-dev/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>

* Update .fleet/context/scripts/neon_learn.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>

* Potential fix for pull request finding 'Empty except'

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>

---------

Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant