Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>
Bumps [actions/github-script](https://github.com/actions/github-script) from 7.0.1 to 8.0.0. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7.0.1...ed59741) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zachary BENSALEM <zachary@qredence.ai>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5.0.1...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zachary BENSALEM <zachary@qredence.ai>
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>
Updates the requirements on [typer](https://github.com/fastapi/typer) to permit the latest version. - [Release notes](https://github.com/fastapi/typer/releases) - [Changelog](https://github.com/fastapi/typer/blob/master/docs/release-notes.md) - [Commits](fastapi/typer@0.20.0...0.21.0) --- updated-dependencies: - dependency-name: typer dependency-version: 0.21.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zachary BENSALEM <zachary@qredence.ai>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Summary of ChangesHello @Zochory, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on essential maintenance and cleanup tasks. It removes outdated architectural documentation for AgenticFleet, updates GitHub Actions workflows to leverage newer and more secure versions of critical actions, and enhances a core logging utility to ensure better sanitization of log entries. Additionally, a minor dependency version range for Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the typer dependency and refactors the sanitize_for_logging function. The dependency update is a minor version bump and seems fine. However, the refactoring of the sanitization function introduces several redundant and inefficient steps. I have provided a review comment with a suggested simplification to improve efficiency and maintainability.
| cleaned = text.replace("\r", " ").replace("\n", " ") | ||
| # Remove all control characters (0x00-0x1f includes CR, LF, tabs) | ||
| # and extended control characters (0x7f-0x9f). | ||
| cleaned = re.sub(r"[\x00-\x1f\x7f-\x9f]", " ", cleaned) | ||
| # Collapse runs of whitespace to a single space. | ||
| cleaned = re.sub(r"\s+", " ", cleaned).strip() | ||
| # Finally, drop any remaining characters outside a conservative safe set | ||
| # Restrict to printable ASCII characters only. | ||
| cleaned = re.sub(r"[^\x20-\x7e]", "", cleaned) | ||
| # Finally, drop any remaining characters outside a conservative safe set. | ||
| return re.sub(r"[^\w\-\.@:/ ]", "", cleaned) |
There was a problem hiding this comment.
This sequence of sanitization steps can be simplified for better efficiency and readability. Some steps are redundant:
- The initial
replace("\r", " ").replace("\n", " ")is redundant because the subsequentre.sub(r"[\x00-\x1f\x7f-\x9f]", ...)already handles newline characters (\nis\x0a,\ris\x0d). - The
re.sub(r"[^\x20-\x7e]", ...)to remove non-printable ASCII is also redundant. The final whitelist[^\w\-\.@:/ ]only contains printable ASCII characters, so any non-printable characters would be removed by the final step anyway.
The implementation can be simplified to be more efficient, closer to its original version.
| cleaned = text.replace("\r", " ").replace("\n", " ") | |
| # Remove all control characters (0x00-0x1f includes CR, LF, tabs) | |
| # and extended control characters (0x7f-0x9f). | |
| cleaned = re.sub(r"[\x00-\x1f\x7f-\x9f]", " ", cleaned) | |
| # Collapse runs of whitespace to a single space. | |
| cleaned = re.sub(r"\s+", " ", cleaned).strip() | |
| # Finally, drop any remaining characters outside a conservative safe set | |
| # Restrict to printable ASCII characters only. | |
| cleaned = re.sub(r"[^\x20-\x7e]", "", cleaned) | |
| # Finally, drop any remaining characters outside a conservative safe set. | |
| return re.sub(r"[^\w\-\.@:/ ]", "", cleaned) | |
| # Remove all control characters (0x00-0x1f includes CR, LF, tabs) | |
| # and extended control characters (0x7f-0x9f). | |
| cleaned = re.sub(r"[\x00-\x1f\x7f-\x9f]", " ", text) | |
| # Collapse runs of whitespace to a single space. | |
| cleaned = re.sub(r"\s+", " ", cleaned).strip() | |
| # Finally, drop any remaining characters outside a conservative safe set. | |
| return re.sub(r"[^\w\-\.@:/ ]", "", cleaned) |
* chore: Remove outdated documentation and style guides - Deleted the technical whitepaper for AgenticFleet, which detailed the architecture and design principles. - Removed general code style principles, Python style guide summary, TypeScript style guide summary, product guidelines, and product overview documents. - Cleared out the tech stack documentation and project tracks, including metadata and plans for refactoring. - Eliminated the setup state file and workflow documentation to streamline the repository. * chore(memory): update .gitignore to track shared knowledge blocks - Track core/project.md and core/persona.md (shared architecture & guidelines) - Track blocks/ (shared topic knowledge) - Track system/ (agent definitions like fleet-agent) - Track skills/memory-system-guide.md (documentation) - Keep ignored: human.md, skills/*.md, recall/**/*, .chroma/*, .neon/* * feat: add documentation agent and related configurations - Introduced a new configuration file `opencode.jsonc` for MCP context. - Updated `pyproject.toml` to include `psycopg2-binary` as a dependency. - Added `get_documentation_instructions` function in `prompts.py` for documentation agent. - Configured the documentation agent in `workflow_config.yaml` with model, instructions, and capabilities. - Updated `uv.lock` to include `psycopg2-binary` with version 2.9.11. * merge main (#509) * Potential fix for code scanning alert no. 172: Log Injection Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Zachary BENSALEM <zachary@qredence.ai> * chore(deps): bump actions/github-script from 7.0.1 to 8.0.0 (#501) Bumps [actions/github-script](https://github.com/actions/github-script) from 7.0.1 to 8.0.0. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7.0.1...ed59741) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zachary BENSALEM <zachary@qredence.ai> * chore(deps): bump actions/checkout from 5.0.1 to 6.0.1 (#499) Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5.0.1...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zachary BENSALEM <zachary@qredence.ai> * Delete .fleet/AgenticFleet_Synthesis.md Signed-off-by: Zachary BENSALEM <zachary@qredence.ai> * Delete .fleet/technical.md Signed-off-by: Zachary BENSALEM <zachary@qredence.ai> * chore(deps): update typer requirement (#503) Updates the requirements on [typer](https://github.com/fastapi/typer) to permit the latest version. - [Release notes](https://github.com/fastapi/typer/releases) - [Changelog](https://github.com/fastapi/typer/blob/master/docs/release-notes.md) - [Commits](fastapi/typer@0.20.0...0.21.0) --- updated-dependencies: - dependency-name: typer dependency-version: 0.21.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zachary BENSALEM <zachary@qredence.ai> --------- Signed-off-by: Zachary BENSALEM <zachary@qredence.ai> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: update typer dependency version range to allow for newer releases * Potential fix for pull request finding 'Empty except' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Signed-off-by: Zachary BENSALEM <zachary@qredence.ai> * fix: replace hardcoded CONTEXT7_API_KEY with environment variable * Update .claude/skills/feature-dev/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Zachary BENSALEM <zachary@qredence.ai> * Update .fleet/context/scripts/neon_learn.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Zachary BENSALEM <zachary@qredence.ai> * Potential fix for pull request finding 'Empty except' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Signed-off-by: Zachary BENSALEM <zachary@qredence.ai> --------- Signed-off-by: Zachary BENSALEM <zachary@qredence.ai> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This pull request removes two major documentation files describing the AgenticFleet architecture and updates GitHub Actions workflow files to use newer versions of key actions. The documentation removals eliminate both the overview and technical whitepaper for AgenticFleet, while the workflow changes upgrade the
actions/checkoutandactions/github-scriptactions to newer commit SHAs and versions.The most important changes are:
Documentation Removal:
.fleet/AgenticFleet_Synthesis.md, which provided a high-level architectural overview, design philosophy, and integration details for AgenticFleet..fleet/technical.md, which contained the technical whitepaper outlining AgenticFleet's layered architecture, orchestration pipeline, and production principles.GitHub Actions Workflow Updates:
actions/checkoutto a newer commit SHA (8e8c483db84b4bee98b60c0593521ed34d9990e8) in.github/workflows/ci-doctor.lock.yml,.github/workflows/docs-sync.aw.lock.yml, and.github/workflows/q.lock.ymlto ensure the latest fixes and improvements are used. [1] [2] [3] [4] [5] [6]actions/github-scriptfrom v7.0.1 to v8.0.0 in the same workflow files, providing compatibility with the latest GitHub Actions APIs and features. [1] [2] [3] [4] [5]## Description