Stabilize Codecov upload#181
Merged
Merged
Conversation
rafaelha
marked this pull request as ready for review
July 21, 2026 21:29
Contributor
|
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fail_ci_if_error: trueso genuine upload failures still fail CIRoot cause
The test suite was passing, but one matrix job would intermittently fail while
codecov/codecov-action@v7fetched and imported its GPG public key. The failed key response producedgpg: no valid OpenPGP data found, and rerunning succeeded after the upstream endpoint recovered.Running four identical coverage uploads increased exposure to that external failure and made it appear tied to whichever Python job encountered it.
Impact
Coverage is uploaded once from Python 3.12, which is already the job that archives
coverage.xml. The PR coverage-comment job and the full Python test matrix remain unchanged.Validation
batch_sizeerrors intest/unit/benchmarks/clifft_benchmarks.py, unrelated to this workflow-only change