-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: rotate cloud sessions on project switch #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
historyStartexceeds the currentlen(messages)(for example, after/loadreplacesag.Historywith a shorter saved session),CompleteCurrentresetsstartto0and uploadsmessages[0:]. This violates the project-scoping invariant: messages that predate the active cloud session are uploaded to the finalizing session. Capstartatlen(messages)instead so the slice is empty when local history has been truncated.Example:
Current:
Proposed:
More Info
/loads a shorter saved session, and later exits (or switches projects again) causes the finalizing cloud session to receive messages from the loaded session. Those messages may belong to a different project or an earlier conversation, leaking context and inflating the event count/token totals for the wrong project.internal/session/cloud_session.golines 117-121:CompleteCurrentslicesmessages[start:]after thestart > len(messages)guard resetsstartto0. The retrieval snapshot forinternal/repl/repl.goshows/loadreplacingag.Historywithout touching the tracker.projectTokens < 0clamp prevents negative token totals, but there is no equivalent guard for the history slice.SwitchProjectandStartWithHistoryonly sethistoryStarttolen(messages)at session creation; neither/loadnor any other visible path updates it whenag.Historyis replaced.start > len(messages)capsstartatlen(messages), producing an empty slice when local history has been truncated. Optionally resethistoryStart/tokenStartwhen/loadreplaces history, but the local cap is the minimal fix./loadis broader and would lose the in-progress cloud session; capping the slice preserves the existing session while avoiding cross-project data leakage./loadafter cloud session start, but when it happens it silently uploads wrong messages to the wrong project. It is not a crash but a data-scoping/information-leak bug.Prompt To Fix With AI