Skip to content

QUA-1024: Highlight all duplicate group rows in Unique check Sample Data#1138

Open
RafaelOsiro wants to merge 2 commits into
mainfrom
qua-1024-unique-check-sample-data
Open

QUA-1024: Highlight all duplicate group rows in Unique check Sample Data#1138
RafaelOsiro wants to merge 2 commits into
mainfrom
qua-1024-unique-check-sample-data

Conversation

@RafaelOsiro

@RafaelOsiro RafaelOsiro commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Overview

Paints every row of each duplicate group in the Unique check Sample Data tables, since the platform reports all duplicate-group rows as source records (not just the second occurrence).

Key Changes

  • Unique > Examples > Single-Field Primary Key: row 1 (customer_id = 1001) now painted alongside row 3 as part of the same duplicate group
  • Unique > Examples > Composite Key on Order Items: row 1 ((5001, 1)) now painted alongside row 3 as part of the same duplicate group
  • Unique > Examples > Scoped Uniqueness with Filter: row 1 ((u-77, login)) now painted alongside row 3 as part of the same duplicate group

Pages to Test

@RafaelOsiro RafaelOsiro added the documentation Improvements or additions to documentation label Jun 10, 2026
@RafaelOsiro RafaelOsiro self-assigned this Jun 10, 2026
@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR corrects the sample data tables in the Unique check examples page so that the visual highlighting matches the platform's actual behavior — every row in a duplicate group is flagged, not only the second occurrence.

  • Single-Field Primary Key, Composite Key on Order Items, and Scoped Uniqueness with Filter tables each have their first duplicate row (previously un-highlighted) wrapped in <span class="text-negative"> to match the third table row that was already highlighted.
  • The fix aligns with the existing prose ("both rows are reported as part of the duplicate group") and the INNER JOIN logic in the equivalent SQL snippets, both of which were already accurate before this change.

Confidence Score: 5/5

Documentation-only change with no runtime code affected; safe to merge.

All three sample data tables are updated consistently and symmetrically — the same text-negative span pattern already used on the second duplicate row is now applied to the first. The change aligns the visual with the prose descriptions and equivalent SQL snippets that were already correct, so there is no risk of introducing a contradiction in the docs.

No files require special attention.

Important Files Changed

Filename Overview
docs/data-quality-checks/unique/examples.md Adds text-negative span highlighting to row 1 of all three sample data tables so both rows in each duplicate group are visually flagged, matching the platform behavior and existing prose/SQL descriptions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Duplicate group detected\n(e.g. customer_id = 1001)"] --> B["INNER JOIN: find all rows\nmatching the duplicate key"]
    B --> C["Row 1 — first occurrence\n highlighted text-negative"]
    B --> D["Row N — second occurrence\n highlighted text-negative"]
    C & D --> E["Both rows emitted as\nsource anomaly records"]

    style C fill:#ffd6d6,stroke:#cc0000
    style D fill:#ffd6d6,stroke:#cc0000
    style E fill:#fff3cd,stroke:#856404
Loading

Reviews (1): Last reviewed commit: "docs(unique): highlight all duplicate gr..." | Re-trigger Greptile

Replaces the legacy text-negative spans (red text only) on duplicate-
group rows in the three Sample Data tables across unique/examples.md
with the new .anomalous-cell utility class, which renders each
anomalous cell with an orange outline and warning-tinted background.
This mirrors the source-records-container.vue treatment in the
Qualytics frontend and keeps the Sample Data visual treatment
consistent with the new pattern introduced for Expected Values and
Entity Resolution.

The .anomalous-cell class is also added to docs/stylesheets/extra.css
on this branch (the same block is in the Expected Values and Entity
Resolution restructure PRs; git auto-deduplicates identical additions
at merge time, so no conflicts will surface).

@ets ets left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — greptile-apps scored this 5/5.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants