QUA-1024: Restructure Expected Values check docs#1140
Conversation
…mples/api/faq Splits the legacy single-page Expected Values rule type doc into the cluster pattern used by Unique and Entity Resolution: - introduction.md: definition, overview, field scope, accepted types, general/specific properties (with spacing-warning include), anomaly types, plain-text Next Steps cards. - how-it-works.md: full semantics on NULL handling, type coercion, case/whitespace sensitivity, array auto-element evaluation, filter ordering, coverage tolerance, Record/Shape anomaly templates, source-records rendering, and pairings with related rule types. - examples.md: three scenarios (status enum, country code with filter, Array[String] element-wise). Sample Data tables mirror the app's source-records view, with the new .anomalous-cell utility class reproducing the orange-outline + warning-tinted background applied in source-records-container.vue. - api.md: endpoints, payload, and field notes. - faq.md: NULL, case, whitespace, arrays, anomaly reporting, configuration. Other changes: - mkdocs.yml: nav now points at the cluster; legacy paths checks/expected-values-check.md and data-quality-checks/expected-values-check.md redirect to expected-values/introduction.md so existing bookmarks keep working. - overview-of-a-check.md and rule-types-overview.md: cross-link updated to the new introduction. - components/general-props/warning.md: rewrote the spacing-warning copy to match the current frontend behavior (chip color change only, no tooltip) and dropped the now-redundant screenshot. Validated against Qualytics/frontend-app@develop:src/components/common/form-builder/item.vue:274. - stylesheets/extra.css: adds .anomalous-cell utility used by the Examples sample-data tables. - expected-values-check.md and warning.png: removed. Source verification: rule semantics, anomaly message templates, and array auto-flag behavior were validated against Qualytics/controlplane, Qualytics/dataplane, and Qualytics/sparqy on develop.
Greptile SummaryThis PR restructures the Expected Values check documentation from a single flat page into a five-page cluster (Introduction, How It Works, Examples, API, FAQ) matching the pattern already established by the Unique check. Legacy URLs are preserved via
Confidence Score: 4/5Safe to merge after fixing the whitespace contradiction in the FAQ; all other changes are structural documentation with correct redirects and CSS. The "Is whitespace trimmed? No" answer and the "pasting trims per line" answer in the same FAQ document give users opposite information about whether their list entries will have spaces stripped. A user copying values from a spreadsheet will believe trimming happens; a user reading the general whitespace answer will believe it never does. One of those answers needs to be qualified before users act on the wrong expectation. docs/data-quality-checks/expected-values/faq.md — the whitespace-trimming Q&A and the paste Q&A need to be reconciled to avoid contradictory guidance. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
OLD["data-quality-checks/expected-values-check.md\n(deleted)"]
REDIRECT1["Redirect: checks/expected-values-check.md"]
REDIRECT2["Redirect: data-quality-checks/expected-values-check.md"]
INTRO["introduction.md\n(cluster entry)"]
HIW["how-it-works.md"]
EX["examples.md"]
API["api.md"]
FAQ["faq.md"]
OVERVIEW["overview-of-a-check.md"]
RTOVERVIEW["rule-types-overview.md"]
CSS["extra.css\n(.anomalous-cell + --q-orange-rgb)"]
WARNING["components/general-props/warning.md\n(spacing-warning component)"]
OLD -->|"replaced by"| INTRO
REDIRECT1 -->|"302"| INTRO
REDIRECT2 -->|"302"| INTRO
INTRO --> HIW
INTRO --> EX
INTRO --> API
INTRO --> FAQ
OVERVIEW -->|"link updated"| INTRO
RTOVERVIEW -->|"link updated"| INTRO
CSS -->|"styles anomalous cells in"| EX
WARNING -->|"included in"| INTRO
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
OLD["data-quality-checks/expected-values-check.md\n(deleted)"]
REDIRECT1["Redirect: checks/expected-values-check.md"]
REDIRECT2["Redirect: data-quality-checks/expected-values-check.md"]
INTRO["introduction.md\n(cluster entry)"]
HIW["how-it-works.md"]
EX["examples.md"]
API["api.md"]
FAQ["faq.md"]
OVERVIEW["overview-of-a-check.md"]
RTOVERVIEW["rule-types-overview.md"]
CSS["extra.css\n(.anomalous-cell + --q-orange-rgb)"]
WARNING["components/general-props/warning.md\n(spacing-warning component)"]
OLD -->|"replaced by"| INTRO
REDIRECT1 -->|"302"| INTRO
REDIRECT2 -->|"302"| INTRO
INTRO --> HIW
INTRO --> EX
INTRO --> API
INTRO --> FAQ
OVERVIEW -->|"link updated"| INTRO
RTOVERVIEW -->|"link updated"| INTRO
CSS -->|"styles anomalous cells in"| EX
WARNING -->|"included in"| INTRO
Reviews (2): Last reviewed commit: "docs(expected-values): apply Greptile re..." | Re-trigger Greptile |
- warning.md: note the alert-icon tooltip that lists values with extra spaces; the frontend still renders it next to the field title. - examples.md: soften the source-records comparison since the doc cell adds a background tint that the in-app outline-only cell does not. - extra.css: introduce --q-orange-rgb so the .anomalous-cell background and border stay coupled to a single orange token.
|
@greptileai review |
Overview
Restructures the Expected Values check docs into the cluster pattern (Introduction / How It Works / Examples / API / FAQ) used by Unique and Entity Resolution.
Key Changes
.anomalous-cellutility class (orange outline + warning-tinted background).Author/Reporterteam-permission phrasing.warning.pngdeleted.overview-of-a-check.mdandrule-types-overview.mdnow point at the new Introduction.mkdocs.ymladds redirects fromchecks/expected-values-check.mdanddata-quality-checks/expected-values-check.mdso existing bookmarks keep working.Pages to Test
shipexamples plus the alert-icon tooltip note.is not in the list of expected values.X,BR,["tech", "gossip"]) render with orange outline + tinted background, not red text.o_orderstatus, no Related section at bottom.