QUA-1024: Restructure Aggregation Comparison check docs#1151
QUA-1024: Restructure Aggregation Comparison check docs#1151RafaelOsiro wants to merge 2 commits into
Conversation
Greptile SummaryThis PR restructures the Aggregation Comparison check documentation from a single legacy page into a five-page hub (
Confidence Score: 5/5Pure documentation restructuring with no executable code changes; all cross-references resolve to existing files and both redirects are correctly wired in mkdocs.yml. Every changed file is documentation or stylesheet. The five new hub pages are internally consistent, all relative links point to verified files, the two legacy-URL redirects are correctly added, and the CSS addition uses the CSS variable throughout rather than hardcoding values. No logic, data, or runtime behavior is affected. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Legacy single-page doc\naggregation-comparison-check.md\n(deleted)"] -->|replaced by| B["Hub: aggregation-comparison/"]
B --> C["introduction.md\nDefinition · Field Scope · Properties · Next Steps"]
B --> D["how-it-works.md\nEvaluation Flow · NULL Handling · Filters · Anomaly Format"]
B --> E["examples.md\n3 production scenarios with payloads + SQL"]
B --> F["api.md\nEndpoints · Permissions · Field Notes · PUT matrix"]
B --> G["faq.md\n15 questions: Behavior / Anomaly Reporting / Configuration"]
H["mkdocs.yml"] -->|nav nested under hub| B
H -->|redirect: checks/aggregation-comparison-check.md| C
H -->|redirect: data-quality-checks/aggregation-comparison-check.md| C
I["overview-of-a-check.md"] -->|link updated| C
J["rule-types-overview.md"] -->|link updated| C
K["extra.css"] -->|adds .anomalous-cell| E
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["Legacy single-page doc\naggregation-comparison-check.md\n(deleted)"] -->|replaced by| B["Hub: aggregation-comparison/"]
B --> C["introduction.md\nDefinition · Field Scope · Properties · Next Steps"]
B --> D["how-it-works.md\nEvaluation Flow · NULL Handling · Filters · Anomaly Format"]
B --> E["examples.md\n3 production scenarios with payloads + SQL"]
B --> F["api.md\nEndpoints · Permissions · Field Notes · PUT matrix"]
B --> G["faq.md\n15 questions: Behavior / Anomaly Reporting / Configuration"]
H["mkdocs.yml"] -->|nav nested under hub| B
H -->|redirect: checks/aggregation-comparison-check.md| C
H -->|redirect: data-quality-checks/aggregation-comparison-check.md| C
I["overview-of-a-check.md"] -->|link updated| C
J["rule-types-overview.md"] -->|link updated| C
K["extra.css"] -->|adds .anomalous-cell| E
Reviews (2): Last reviewed commit: "docs(aggregation-comparison): apply Grep..." | Re-trigger Greptile |
Use color-mix(in srgb, var(--q-orange) 12%, transparent) so the .anomalous-cell background tracks --q-orange instead of duplicating its RGB triplet.
|
@greptileai review |
Overview
Restructure the Aggregation Comparison rule type documentation from a single page into the 5-page hub pattern (Introduction, How It Works, Examples, API, FAQ), aligned with the QUA-1024 playbook used for Unique, AI Managed, Data Diff, Entity Resolution, Expected Values, and After Date Time.
Key Changes
docs/data-quality-checks/aggregation-comparison/withintroduction.md,how-it-works.md,examples.md,api.md, andfaq.md. H1 icons follow the Standard Icons convention (book-open-variant,file-cog, no icon for Examples,api,help-circle-outline).filterandref_filter), an explicit "Coverage is not used" section, anomaly message format with both filter suffixes, Shape-only behavior (no Source Records highlighting), relationship with Volumetric / Data Diff / Metric, and performance considerations.properties.expression/comparison/ref_datastore_id/ref_container_id/ref_expression/ref_filter, field notes table, andPUTeditable/immutable lists (3 immutables:rule,container_id,template_id). Explicit note thatcoverageandanomaly_message_fieldare ignored for this rule.extra.css: adds the.anomalous-cellclass to highlight individual table cells in Examples sample aggregates.mkdocs.yml: nested nav under "Aggregation Comparison" plus redirects fromchecks/aggregation-comparison-check.mdanddata-quality-checks/aggregation-comparison-check.mdto the new introduction.overview-of-a-check.mdandrule-types-overview.mdrepointed to the new hub path.docs/data-quality-checks/aggregation-comparison-check.md.Pages to Test
book-open-variant, Specific Properties table shows six properties with Comparison long-form labels, Next Steps cards (How It Works hasfile-cog, Examples has no icon, API hasapi, FAQ hashelp-circle-outline)filterandref_filter, Source Records Behavior states it does not apply[filter: load_date = current_date()] [reference filter: updated_at >= current_date()]fieldsrow marked "No"; explicit note thatcoverageandanomaly_message_fieldare ignored; Immutable list hasrule,container_id,template_idMetricandData Diffcomparisons present