FIX: execution errors in notebooks#277
Open
mmcky wants to merge 2 commits into
Open
Conversation
- Fix MLPRegressor API calls in ml_in_economics.md and regression.md - Changed positional tuple arg to hidden_layer_sizes= keyword argument - Required due to scikit-learn API change where first positional arg is now 'loss' - Fix broken Avalanche Canada API in working_with_text.md - API endpoint now returns 404 - Load incident data directly from cached CSV file instead
mmcky
changed the title
Contributor
Author
|
@doctor-phil just some suggestions to fix the current execution failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes execution errors discovered during a full CI execution check.
Issues Fixed
1. MLPRegressor API Change (scikit-learn)
Files:
lectures/applications/ml_in_economics.md,lectures/tools/regression.mdThe scikit-learn API for
MLPRegressorhas changed - the first positional argument is nowlossinstead ofhidden_layer_sizes. This was causing all 40 fits to fail with:Fix: Changed positional tuple arguments to use the explicit
hidden_layer_sizes=keyword argument.2. Broken Avalanche Canada API
File:
lectures/applications/working_with_text.mdThe Avalanche Canada incidents API (
http://incidents.avalanche.ca/public/incidents/) now returns HTTP 404.Fix: Load incident data directly from the cached CSV file (
avalanche_incidents.csv) which already contains all the required data.Testing
These changes should be validated by the CI execution check.