chore(deps): clear Dependabot security alerts#385
Merged
Conversation
Bumps transitive dev dependencies via npm audit fix and upgrades two direct devDependencies whose patched versions required a major bump: - css-minimizer-webpack-plugin: ^7.0.2 → ^8.0.0 (clears serialize-javascript RCE/DoS advisories GHSA-5c6j-r48x-rmvq, GHSA-qj8w-gfj5-8c6v) - sass: ^1.94.2 → ^1.99.0 (clears immutable prototype-pollution advisory GHSA-wf6x-7x77-mvgw) `npm audit` now reports 0 vulnerabilities. All affected packages are dev/build-time only; no runtime/shipped code is changed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ment css-minimizer-webpack-plugin@8 and serialize-javascript@7 require Node >= 20. Bumps sphinx-theme-builder's nodeenv pin from 18.18.0 to 20.18.0 and the matching setup-node version across CI/docs/update-snapshots workflows. Without this, the editable install fails with 'ReferenceError: crypto is not defined' inside serialize-javascript. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Node.js build-time dependencies (primarily via npm audit fix) to clear Dependabot security alerts affecting the theme’s asset build toolchain (webpack/Sass/CSS minification), without changing shipped theme source.
Changes:
- Bump direct devDependencies:
css-minimizer-webpack-pluginto^8.0.0andsassto^1.99.0. - Refresh
package-lock.jsonto incorporate patched transitive dependency versions and remove reportednpm auditvulnerabilities.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates direct build tool devDependencies to patched versions. |
| package-lock.json | Updates transitive dependency graph/versions to remove security advisories. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=======================================
Coverage ? 47.75%
=======================================
Files ? 2
Lines ? 423
Branches ? 0
=======================================
Hits ? 202
Misses ? 221
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Completes the Node 20 migration flagged by Copilot review on PR #385. Aligns .nvmrc, CONTRIBUTING.md, and docs/developer/setup.md with the sphinx-theme-builder node-version pin and the CI setup-node version. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
🎭 Visual Regression Test Results
Details
Skipped testsmobile-chrome › theme.spec.ts › Theme Features › f-string interpolation styling |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 13 open Dependabot alerts on
main. All affected packages are transitive dev/build-time dependencies — no runtime or shipped theme code is changed.npm audit fixto bump transitive lockfile entries (fast-uri, follow-redirects, lodash, node-forge, picomatch, svgo, etc.)devDependencieswhose patched versions required a major bump:css-minimizer-webpack-plugin:^7.0.2→^8.0.0— clearsserialize-javascriptadvisories GHSA-5c6j-r48x-rmvq (high, RCE) and GHSA-qj8w-gfj5-8c6v (moderate, DoS)sass:^1.94.2→^1.99.0— clearsimmutableprototype pollution GHSA-wf6x-7x77-mvgw (high)npm auditnow reports 0 vulnerabilitiesnpm run buildsucceeds; output artifacts unchanged in sizeTest plan
tests.ymlpasses (Playwright visual regression suite)ci.ymlpassesmain🤖 Generated with Claude Code