Add Subreddit to Multireddit#1251
Open
mrboisvert wants to merge 7 commits intoQuantumBadger:masterfrom
Open
Conversation
mrboisvert
force-pushed
the
add-subredd-to-multi
branch
4 times, most recently
from
58a3925 to
9a4d736
Compare
Author
|
There is also a commit in here refactoring CacheRequest to use a builder. I can drop it if it doesn't seem necessary. |
mrboisvert
force-pushed
the
add-subredd-to-multi
branch
from
9a4d736 to
629e61a
Compare
mrboisvert
force-pushed
the
add-subredd-to-multi
branch
from
629e61a to
feac34a
Compare
mrboisvert
force-pushed
the
add-subredd-to-multi
branch
from
feac34a to
6d812ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@QuantumBadger awesome app, I've been using it for ages. Thought I would take a shot at adding a multireddit management feature that I've wanted for a while.
This MR adds a subreddit action 'Add to Multireddit'. Users can add a subreddit to a multireddit, or create a multireddit while adding a subreddit to it at the same time. This also does some refactoring to support making PUT requests, which I used to implement the 'Add to Multireddit' action.
The endpoint for adding a subreddit to a multireddit returns 201 on success and 400 if an illegal multireddit name is used. This MR also adds handling for these status codes.
Related to #15 . This doesn't quite make the multireddits fully editable though.