Remove disabling starting updatevm under some conditions#218
Closed
marmarta wants to merge 1 commit into
Closed
Conversation
When qubes-dom0-update was run with --check-only, it never started updatevm if it wasn't running. This causes problems with gui updater, but also doesn't seem to be very logical. Removed the check. fixes QubesOS/qubes-issues#10006
Member
Author
|
I'm open to other ways of fixing it, btw. It just looks like this check was True for more than just "running in cron". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 72.63% 71.74% -0.89%
==========================================
Files 10 12 +2
Lines 1162 1338 +176
==========================================
+ Hits 844 960 +116
- Misses 318 378 +60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
This will have consequences on daily updates check. When user stops updatevm, with this change the daily updates check will start it again, which may even happen just after user stopped it. This may be at least surprising... |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026070916-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests26 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 22 fixed
Unstable testsDetails
Performance TestsPerformance degradation:34 performance degradations
Remaining performance tests:75 tests
|
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When qubes-dom0-update was run with --check-only, it never started updatevm if it wasn't running. This causes problems with gui updater, but also doesn't seem to be very logical. Removed the check.
fixes QubesOS/qubes-issues#10006